Percona Toolkit moved to https://jira.percona.com/projects/PT

Merge lp:~edgarsi/percona-toolkit/osc-stop-restart into lp:percona-toolkit/2.2

  1. osc-stop-restart
  2. Merge into 2.2
Proposed by Edgars Irmejs
Status: Needs review
Proposed branch: lp:~edgarsi/percona-toolkit/osc-stop-restart
Merge into: lp:percona-toolkit/2.2
Diff against target: 18 lines (+2/-2)
1 file modified
bin/pt-online-schema-change (+2/-2)
To merge this branch: bzr merge lp:~edgarsi/percona-toolkit/osc-stop-restart
Reviewer Review Type Date Requested Status
Percona Toolkit developers Pending
Review via email: mp+217118@code.launchpad.net

Description of the change

Some work regarding this: https://blueprints.launchpad.net/percona-toolkit/+spec/osc-stop-restart

Although I do not understand the requirement for an interactive stop/restart, I have had problems stopping/continuing the process, specifically "MySQL server has gone away". I believe the default settings should avoid such errors, when possible.

I haven't noticed other problems with stopping pt-online-schema-change but neither have tested much.

To post a comment you must log in.

Unmerged revisions

599. By Edgars Irmejs

Increase wait_timeout from 10000 to 2000000. Small wait_timeout has no practical usefulness. Larger timeout permits pausing the process for longer intervals without surprises.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'bin/pt-online-schema-change'
2--- bin/pt-online-schema-change 2014-02-20 08:10:16 +0000
3+++ bin/pt-online-schema-change 2014-04-24 18:08:48 +0000
4@@ -11197,13 +11197,13 @@
5 =for comment ignore-pt-internal-value
6 MAGIC_set_vars
7
8- wait_timeout=10000
9+ wait_timeout=2000000
10 innodb_lock_wait_timeout=1
11 lock_wait_timeout=60
12
13 Variables specified on the command line override these defaults. For
14 example, specifying C<--set-vars wait_timeout=500> overrides the default
15-value of C<10000>.
16+value of C<2000000>.
17
18 The tool prints a warning and continues if a variable cannot be set.
19

Subscribers

People subscribed via source and target branches