Code review comment for lp:~edgar-b-dsouza/acire/snippet_dependency_res_1

Revision history for this message
Ed S (edgar-b-dsouza) wrote :

On Mon, Mar 29, 2010 at 1:26 AM, Jono Bacon <email address hidden> wrote:
> Hi Ed,
>
> I just wanted to let you know that I am finding more and more bug fixes that I need to fix in Acire, so I expect lp:acire to change more frequently. I just wanted to make sure I gave you a heads up this to keep syncing your branch with lp:acire.
>
> We discussed this before, but I would still recommend you keep the vast majority of your logic in a separate source file (e.g. depchecker.py) and then just hook it into bin/acire to integrate it into the app. This will mean that the regular changes in bin/acire will not screw up your branch. :-)

Thanks for the heads-up, Jono... I tried updating the other day, and
Bazaar Explorer tells me I'm already on a "divergent" branch :-P so
what I'm doing is just what you say - keep as much of the new code as
possible outside bin/acire and its .ui file. That will make merging
easier for me just before uploading for merge proposal. I'm still
refactoring/writing new code/testing and debugging, so merge proposal
is a few days away yet (had some other things take up time, so haven't
put in as much time as I'd like on Acire). My paying work cycle starts
on the 8th (to the 21st) so I intend to have this feature merged (or
at least proposed) by then, since I'll most likely be unable to work
on the project at all during those days.

Thanks,
Ed.

« Back to merge proposal