Code review comment for lp:~edgar-b-dsouza/acire/snippet_dependency_res_1

Revision history for this message
Jono Bacon (jonobacon) wrote :

> > Another contributor is actually working on clearing the terminal. :-)
> Ah - OK, good. I'm curious to see if s/he finds any other way than
> resetting the terminal, which is all I could figure out.

This is now committed: it was using vte.reset() - it clears the terminal before running the snippet and works nicely. :-)

As I said before: I recommend you keep pulling from lp:acire to ensure your branch is updated. I have another few bugfixes I need to merge in.

> Er - if I might ask - is there a mailing list, or IRC channel or
> something where contributors discuss?

Nope: the project is pretty small right now, so I think we can just do this in a place such as this until we have more contributors and set up a list.

> >> - shift the Exec/Copy/SaveAs buttonbar below the SourceView
> > Yeah, I have been thinking about this too. We may want to fix this.
> Not a big change, maybe it can be done even before the dep checker.

Personally, I would recommend you focus on the dep checker and not mix features: just makes it easier for us to ensure we get a clean implementation. :-)

> >> - see if I can (at runtime) add the shortcuts for the three buttons
> > Aha, good idea.
> > So maybe we can fix these issues after you land the dep checker?
> If they're not done by then, yes, I will.

Sweet. :-)

« Back to merge proposal