Code review comment for lp:~edgar-b-dsouza/acire/snippet_dependency_res_1

Revision history for this message
Ed S (edgar-b-dsouza) wrote :

On Wed, Mar 24, 2010 at 12:37 PM, Jono Bacon <email address hidden> wrote:
>  1. User loads a snippet that does not have a module installed.
>  2. Above the source view a little bar appears (like the plugin missing bar in Firefox) where it says what module(s) are missing and a button called 'Install'.
>  3. User clicks  the 'Install' button, a dialog box pops up to confirm what will be installed, the user clicks the 'OK' button, is asked for password and then a dialog displays progress of the installation.
>  4. The bar disappears from the snippet.
>
> I would prefer that the code for this feature does not clutter up bin/acire if possible. Probably best is that the logic lives in a file called moduleinstaller.py and there is a separate .py file with the dialog box.
>
> Sound doable?

Yes, but it will take me some time to do the changes, especially
replacing the gnome-terminal with progress dialog - need to research
for how to do that. Give me a few days.

> Q2 - I would like you to sync your branch to the current lp:acire branch and work in your worn branch. We can then test it until it is working and then I will merge it into lp:acire. :-)

I'll get the stuff above working first as you have asked, then update
my local repo to tip and meld in my changes, then push to a feature
branch on LP.

You didn't answer - overwrite/update this same feature branch which
I've proposed for merge, or push to a new one?

Thanks
Ed.

« Back to merge proposal