Code review comment for lp:~edgar-b-dsouza/acire/snippet_dependency_res_1

Revision history for this message
Jono Bacon (jonobacon) wrote :

Thanks Ed for the continued work on this: this is shaping up really nicely!

First, in terms of the UI, why don't you first add a GTK label at the top of the source view which says which modules are required and a button that allows someone to kick off the installation process.

In terms of supporting multiple distros, I love that you have kept the logic separated out into utils.py and it could be useful to first get it running for Ubuntu, we can then focus in on supporting other distributions and merge that logic into utils.py too.

I think for PPA element, the wiki page is ideal: to be quite frank, I am unlikely to accept a snippet if it is not installable from the archive anyway. :-)

Does this sound OK?

Thanks Ed, you rock the house. :-)

« Back to merge proposal