Merge lp:~edersohe/birdie/fix-1156043 into lp:~birdie-team/birdie/trunk-old

Proposed by Eder Sosa
Status: Merged
Merged at revision: 37
Proposed branch: lp:~edersohe/birdie/fix-1156043
Merge into: lp:~birdie-team/birdie/trunk-old
Diff against target: 15 lines (+2/-2)
1 file modified
src/Twitter.vala (+2/-2)
To merge this branch: bzr merge lp:~edersohe/birdie/fix-1156043
Reviewer Review Type Date Requested Status
vasco Approve
Review via email: mp+153993@code.launchpad.net
To post a comment you must log in.
Revision history for this message
vasco (vasco-m-nunes) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Twitter.vala'
2--- src/Twitter.vala 2013-03-17 02:30:05 +0000
3+++ src/Twitter.vala 2013-03-19 05:43:21 +0000
4@@ -288,9 +288,9 @@
5
6 try {
7 urls = new Regex("((http|https|ftp)://([\\S]+))");
8- text = urls.replace(text, -1, 0, "<a href='\\0'>\\0</a>");
9+ text = urls.replace(text, -1, 0, "<span underline='none'><a href='\\0'>\\0</a></span>");
10 urls = new Regex("([@#][a-zA-Z0-9_]+)");
11- text = urls.replace(text, -1, 0, "<a href='https://twitter.com/\\0'>\\0</a>");
12+ text = urls.replace(text, -1, 0, "<span underline='none'><a href='https://twitter.com/\\0'>\\0</a></span>");
13 } catch (RegexError e) {
14 warning ("regex error: %s", e.message);
15 }

Subscribers

People subscribed via source and target branches

to all changes: