Merge lp:~edb/quam-plures/rearrange_config_array into lp:quam-plures

Proposed by EdB
Status: Merged
Merged at revision: 7585
Proposed branch: lp:~edb/quam-plures/rearrange_config_array
Merge into: lp:quam-plures
Diff against target: 31 lines (+4/-12)
1 file modified
qp_config/_main_config.template.php (+4/-12)
To merge this branch: bzr merge lp:~edb/quam-plures/rearrange_config_array
Reviewer Review Type Date Requested Status
Yabs (community) Approve
Review via email: mp+46101@code.launchpad.net

Description of the change

Easy branch: re-ordered the bits in the app_db_config array so that they match the order you are asked to provide them during installation. Also changed the comment on each of those lines to match the field name on the install screen. Trivial, but I'm a friggin retard about stuff like that.

Oh and totally wiped out a todo of some sort.

To post a comment you must log in.
Revision history for this message
Yabs (yabs) wrote :

Aesthetic, but doesn't cause problems.

Would be really cool if others did the occasional review, then I'd be able to spend my free time coding instead of reviewing your branches ( not a dig at you ;) )

¥

review: Approve
Revision history for this message
Yabs (yabs) wrote :

Ohh yeah, bonus points for killing a todo :D

¥

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'qp_config/_main_config.template.php'
2--- qp_config/_main_config.template.php 2010-06-26 18:16:49 +0000
3+++ qp_config/_main_config.template.php 2011-01-13 08:21:16 +0000
4@@ -22,14 +22,6 @@
5 if( !defined('QP_CONFIG_LOADED') ) die( 'Please, do not access this page directly.' );
6
7
8-// TODO: dh> this file was meant to be used for things where you only need the basic config..
9-// fp> also:
10-// - At least _admin.php should only be called when in the backoffice.
11-// - Also we should probably start by moving as many conf options to the backoffice as possible and see how much stuff is left in conf files
12-// Note: some stuff does not make sense in the back-office (for example stuff that depends on the physical path where the files are installed)
13-// - In view of reorganization, please list (all or examples) of situations where only a subset of the conf should be loaded.
14-
15-
16 /**
17 * Maintenance mode. Set this to 1 in order to temporarily disable access to the application.
18 *
19@@ -53,10 +45,10 @@
20 * Fill in your database details (check carefully or nothing will work!)
21 */
22 $app_db_config = array(
23- 'user' => 'demouser', // your MySQL username
24- 'password' => 'demopass', // ...and password
25- 'name' => 'quamplures', // the name of the database
26- 'host' => 'localhost', // MySQL Server (typically 'localhost')
27+ 'host' => 'localhost', // "MySQL Host/Server" (typically 'localhost')
28+ 'name' => 'quamplures', // "MySQL Database"
29+ 'user' => 'demouser', // "MySQL Username"
30+ 'password' => 'demopass', // "MySQL Password"
31 );
32
33

Subscribers

People subscribed via source and target branches