Merge lp:~edb/quam-plures/bring_back_podcasts into lp:quam-plures

[EdB]

http://forums.quamplures.net/viewtopic.php?f=16&t=784

[lp:~edb/quam-plures/bring_back_podcasts]

7602. By EdB on 2011-05-08

youtube patch

[Tilman Blumenbach (tblue)]

Well, now podcasts show up in the admin under "Posts" while they should only show up under "Podcasts" (I guess).

Could be fixed by using is_admin_page() or something like that: Exclude podcasts if it's an admin page, include them if it's the public side. Or maybe one could override "types" if it's an admin page -- set_param()?

review: Needs Fixing

[EdB (edb)]

but a podcast *is* a post. It just happens to need to trigger the podcast player.

no worries.

[Tilman Blumenbach (tblue)]

Ah. Didn't know that. Well, *should* be finde then.

review: Approve

[EdB (edb)]

I don't disagree about needing a good solution by the way. Just that what we have doesn't let a user actually use the podcast thing. IMHO podcast shouldn't even be a post type. Kinda like how a post with an attached image is just a post that happens to do something more than spit out text.

A checkbox to trigger the podcast thing? Or check the URL field file type and podcast the ones that can be even though that makes the assumption that the podcast player is desired? Heck maybe even a plugin-powered button under the textarea where one could fire a podcast renderer?

Sounds like a forum thread eh?

[Tilman Blumenbach (tblue)]

Hm, you are right, that could be a (minor) design issue. The comparison with image posts makes sense and I guess the player should really be implemented by a plugin or as a checkbox-triggered core feature...

Yes. Forum thread. ;)

[Tilman Blumenbach (tblue)]

Forum thread: http://forums.quamplures.net/viewtopic.php?f=6&t=814

[lp:~edb/quam-plures/bring_back_podcasts]

7603. By EdB on 2011-06-17

admin fire tweak

7604. By EdB on 2011-06-24

adding dracones branch

7605. By EdB on 2011-06-25

clean up posting and validating XHTML

[EdB (edb)]

bump.

[Tilman Blumenbach (tblue)]

Well, it would be good if somebody else could test and approve this branch as well...

[lp:~edb/quam-plures/bring_back_podcasts]

7606. By EdB on 2011-07-12

adding core updates

[Tilman Blumenbach (tblue)]

Hold on, it looks like the $posttypes_locked_IDs stuff was introduced as a fix for bug 543480. I think we will have to check whether reverting to the original code (hardcoded list of types to exclude) is okay...

review: Needs Information

[EdB (edb)]

The original bug was "something is hard-coded" and the solution was a different slightly-less hard-coded replacement that caused this problem. There was no actual problem is what I mean, so going back to what was simply removes the problem that was caused and still leaves us something that can not be modified without editing files.

[Tilman Blumenbach (tblue)]

To be honest, I don't even see what the original problem was. There's not much information given in the bug report, and we can't ask yabs. :(

So let's merge this (tomorrow).

review: Approve (merge)

[lp:~edb/quam-plures/bring_back_podcasts]

7607. By EdB on 2011-07-15

committing core commits :)

=== modified file 'qp_inc/items/model/_itemlistlight.class.php'
--- qp_inc/items/model/_itemlistlight.class.php	2010-12-31 12:12:03 +0000
+++ qp_inc/items/model/_itemlistlight.class.php	2011-07-15 04:14:25 +0000
@@ -154,7 +154,7 @@
 				'ymdhms_min' => NULL,
 				'ymdhms_max' => NULL,
 				'statuses' => NULL,
-				'types' => '-'.implode( ',', $GLOBALS['posttypes_locked_IDs'] ),	// All types except pages, intros and sidebar links
+				'types' => '-1000,1500,1520,1530,1570,1600,3000', // All types except pages, intros and sidebar links
 				'visibility_array' => array( 'published', 'protected', 'private' ),
 				'orderby' => $this->Blog->get_setting('orderby'),
 				'order' => $this->Blog->get_setting('orderdir'),