Merge lp:~edb/quam-plures/another_image_branch into lp:quam-plures

Proposed by EdB
Status: Merged
Approved by: Tilman Blumenbach
Approved revision: 7606
Merged at revision: 7610
Proposed branch: lp:~edb/quam-plures/another_image_branch
Merge into: lp:quam-plures
Diff against target: 11 lines (+1/-0)
1 file modified
qp_inc/files/views/_file_list.inc.php (+1/-0)
To merge this branch: bzr merge lp:~edb/quam-plures/another_image_branch
Reviewer Review Type Date Requested Status
Tilman Blumenbach (community) merge Approve
Review via email: mp+66550@code.launchpad.net
To post a comment you must log in.
Revision history for this message
EdB (edb) wrote :

i ran out of punctuation marks to follow a bump with. to be honest even the ellipsis was a reach but it can and does end a sentence so i guess it is okay. this is a bug fix. anybody actually playing anymore?

Revision history for this message
Tilman Blumenbach (tblue) wrote :

Well, I agree things have slowed down a bit again, but I'll try to look at most of the R2Ms today.

Revision history for this message
Tilman Blumenbach (tblue) wrote :

Tested and found to be working.

review: Approve
Revision history for this message
Kimberly (kimberly-netweb360) wrote :

Has this branch anything to do with the comments I made in the forum? I will grab the branch and test as soon as possible. Gardening takes all my time these days.

Revision history for this message
EdB (edb) wrote :

Only if you noticed you can not insert an image that does not have a caption, which is what this branch fixes http://forums.quamplures.net/viewtopic.php?f=16&t=854

Revision history for this message
Tilman Blumenbach (tblue) wrote :

Same here: It would be good if somebody else could test and approve this branch as well.

7606. By EdB

adding core updates

Revision history for this message
Tilman Blumenbach (tblue) wrote :

You're right, EdB, nobody plays here anyway, so I'm just going to merge this.

review: Approve (merge)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'qp_inc/files/views/_file_list.inc.php'
2--- qp_inc/files/views/_file_list.inc.php 2011-02-23 14:42:27 +0000
3+++ qp_inc/files/views/_file_list.inc.php 2011-07-12 19:04:32 +0000
4@@ -677,6 +677,7 @@
5 var caption_class = '<?php echo $file_tags['caption_class']; ?>';
6 var caption_style = '<?php echo $file_tags['caption_style']; ?>';
7 var caption_post = '<?php echo $file_tags['caption_post']; ?>';
8+ var caption_none = '<?php echo $file_tags['caption_none']; ?>';
9 var caption_separator = '<?php echo $file_tags['caption_separator']; ?>';
10
11 var snippet = ''; // this is what we will eventually insert into the item

Subscribers

People subscribed via source and target branches