Merge lp:~eday/burrow/lp803237 into lp:burrow

Proposed by Eric Day
Status: Merged
Approved by: Eric Day
Approved revision: 21
Merged at revision: 21
Proposed branch: lp:~eday/burrow/lp803237
Merge into: lp:burrow
Diff against target: 26 lines (+5/-3)
1 file modified
burrow/backend/sqlite.py (+5/-3)
To merge this branch: bzr merge lp:~eday/burrow/lp803237
Reviewer Review Type Date Requested Status
Burrow Core Team Pending
Review via email: mp+66384@code.launchpad.net

Description of the change

Fixed bug #803237. More query string cleanup to do, will do full review later.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'burrow/backend/sqlite.py'
2--- burrow/backend/sqlite.py 2011-06-10 21:36:49 +0000
3+++ burrow/backend/sqlite.py 2011-06-29 20:44:31 +0000
4@@ -97,8 +97,9 @@
5 yield message
6 if len(ids) == 0:
7 return
8- query = 'DELETE FROM messages WHERE queue=%d AND name IN (%s)'
9- self.db.execute(query % (rowid, ','.join(ids)))
10+ values = (rowid,) + tuple(ids)
11+ query = 'DELETE FROM messages WHERE queue=? AND name IN (%s)'
12+ self.db.execute(query % ','.join('?' * len(ids)), values)
13 query = 'SELECT rowid FROM messages WHERE queue=? LIMIT 1'
14 if len(self.db.execute(query, (rowid,)).fetchall()) == 0:
15 query = 'DELETE FROM queues WHERE rowid=?'
16@@ -142,8 +143,9 @@
17 if comma == '':
18 return
19 values += (rowid,)
20+ values += tuple(ids)
21 query += ' WHERE queue=? AND name IN (%s)'
22- self.db.execute(query % ','.join(ids), values)
23+ self.db.execute(query % ','.join('?' * len(ids)), values)
24 self.notify(account, queue)
25
26 def create_message(self, account, queue, message, body, attributes):

Subscribers

People subscribed via source and target branches