Merge lp:~ed.so/duplicity/move_netloc into lp:~duplicity-team/duplicity/0.7-series

Proposed by edso
Status: Merged
Merged at revision: 1036
Proposed branch: lp:~ed.so/duplicity/move_netloc
Merge into: lp:~duplicity-team/duplicity/0.7-series
Diff against target: 105 lines (+16/-13)
9 files modified
duplicity/backend.py (+3/-11)
duplicity/backends/botobackend.py (+1/-0)
duplicity/backends/copycombackend.py (+1/-0)
duplicity/backends/gdocsbackend.py (+1/-0)
duplicity/backends/hsibackend.py (+1/-0)
duplicity/backends/imapbackend.py (+3/-2)
duplicity/backends/megabackend.py (+1/-0)
duplicity/backends/rsyncbackend.py (+1/-0)
duplicity/backends/webdavbackend.py (+4/-0)
To merge this branch: bzr merge lp:~ed.so/duplicity/move_netloc
Reviewer Review Type Date Requested Status
duplicity-team Pending
Review via email: mp+244964@code.launchpad.net

Description of the change

- move netloc usage definitions into respective backends
- fix "[Question #259173]: rsync backend fails"
  https://answers.launchpad.net/duplicity/+question/259173

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'duplicity/backend.py'
2--- duplicity/backend.py 2014-12-12 14:39:54 +0000
3+++ duplicity/backend.py 2014-12-17 10:39:12 +0000
4@@ -72,17 +72,9 @@
5 # This looks similar to urlparse's 'uses_netloc' list, but urlparse doesn't use
6 # that list for parsing, only creating urls. And doesn't include our custom
7 # schemes anyway. So we keep our own here for our own use.
8-uses_netloc = ['ftp',
9- 'ftps',
10- 'hsi',
11- 's3',
12- 'scp', 'ssh', 'sftp',
13- 'webdav', 'webdavs',
14- 'gdocs',
15- 'http', 'https',
16- 'imap', 'imaps',
17- 'mega',
18- 'copy']
19+#
20+# NOTE: this is filled by the respective backends during registering
21+uses_netloc = []
22
23
24 def import_backends():
25
26=== modified file 'duplicity/backends/botobackend.py'
27--- duplicity/backends/botobackend.py 2014-04-28 02:49:39 +0000
28+++ duplicity/backends/botobackend.py 2014-12-17 10:39:12 +0000
29@@ -31,3 +31,4 @@
30 duplicity.backend.register_backend("gs", BotoBackend)
31 duplicity.backend.register_backend("s3", BotoBackend)
32 duplicity.backend.register_backend("s3+http", BotoBackend)
33+duplicity.backend.uses_netloc.extend([ 'gs', 's3', 's3+http' ])
34
35=== modified file 'duplicity/backends/copycombackend.py'
36--- duplicity/backends/copycombackend.py 2014-12-12 14:39:54 +0000
37+++ duplicity/backends/copycombackend.py 2014-12-17 10:39:12 +0000
38@@ -317,3 +317,4 @@
39 '''
40
41 duplicity.backend.register_backend('copy', CopyComBackend)
42+duplicity.backend.uses_netloc.extend([ 'copy' ] )
43
44=== modified file 'duplicity/backends/gdocsbackend.py'
45--- duplicity/backends/gdocsbackend.py 2014-04-21 19:21:45 +0000
46+++ duplicity/backends/gdocsbackend.py 2014-12-17 10:39:12 +0000
47@@ -183,3 +183,4 @@
48 return result
49
50 duplicity.backend.register_backend('gdocs', GDocsBackend)
51+duplicity.backend.uses_netloc.extend([ 'gdocs' ])
52
53=== modified file 'duplicity/backends/hsibackend.py'
54--- duplicity/backends/hsibackend.py 2014-12-12 14:39:54 +0000
55+++ duplicity/backends/hsibackend.py 2014-12-17 10:39:12 +0000
56@@ -53,3 +53,4 @@
57 self.subprocess_popen(commandline)
58
59 duplicity.backend.register_backend("hsi", HSIBackend)
60+duplicity.backend.uses_netloc.extend([ 'hsi' ])
61
62=== modified file 'duplicity/backends/imapbackend.py'
63--- duplicity/backends/imapbackend.py 2014-12-12 14:39:54 +0000
64+++ duplicity/backends/imapbackend.py 2014-12-17 10:39:12 +0000
65@@ -257,5 +257,6 @@
66 self.conn.close()
67 self.conn.logout()
68
69-duplicity.backend.register_backend("imap", ImapBackend);
70-duplicity.backend.register_backend("imaps", ImapBackend);
71+duplicity.backend.register_backend("imap", ImapBackend)
72+duplicity.backend.register_backend("imaps", ImapBackend)
73+duplicity.backend.uses_netloc.extend([ 'imap', 'imaps' ])
74
75=== modified file 'duplicity/backends/megabackend.py'
76--- duplicity/backends/megabackend.py 2014-04-26 12:35:04 +0000
77+++ duplicity/backends/megabackend.py 2014-12-17 10:39:12 +0000
78@@ -123,3 +123,4 @@
79 return result
80
81 duplicity.backend.register_backend('mega', MegaBackend)
82+duplicity.backend.uses_netloc.extend([ 'mega' ])
83
84=== modified file 'duplicity/backends/rsyncbackend.py'
85--- duplicity/backends/rsyncbackend.py 2014-12-12 14:39:54 +0000
86+++ duplicity/backends/rsyncbackend.py 2014-12-17 10:39:12 +0000
87@@ -154,3 +154,4 @@
88 os.rmdir (dir)
89
90 duplicity.backend.register_backend("rsync", RsyncBackend)
91+duplicity.backend.uses_netloc.extend([ 'rsync' ])
92
93=== modified file 'duplicity/backends/webdavbackend.py'
94--- duplicity/backends/webdavbackend.py 2014-12-12 14:39:54 +0000
95+++ duplicity/backends/webdavbackend.py 2014-12-17 10:39:12 +0000
96@@ -422,5 +422,9 @@
97 finally:
98 if response: response.close()
99
100+duplicity.backend.register_backend("http", WebDAVBackend)
101+duplicity.backend.register_backend("https", WebDAVBackend)
102 duplicity.backend.register_backend("webdav", WebDAVBackend)
103 duplicity.backend.register_backend("webdavs", WebDAVBackend)
104+duplicity.backend.uses_netloc.extend([ 'http', 'https', 'webdav', 'webdavs' ] )
105+

Subscribers

People subscribed via source and target branches