Merge lp:~ech1965/rapid/fix-754531 into lp:rapid/0.0.4

Proposed by Ech
Status: Merged
Merged at revision: 413
Proposed branch: lp:~ech1965/rapid/fix-754531
Merge into: lp:rapid/0.0.4
Diff against target: 63 lines (+25/-6)
3 files modified
rapid/generatename.py (+13/-6)
rapid/generatenameconfig.py (+2/-0)
rapid/metadataphoto.py (+10/-0)
To merge this branch: bzr merge lp:~ech1965/rapid/fix-754531
Reviewer Review Type Date Requested Status
Damon Lynch Approve
Review via email: mp+78483@code.launchpad.net

Commit message

Fix for bug #754531 : Correctly format shutter_count for Canon 400D and add formatting option to extract the DCIM directory Name from the shutter count

Description of the change

Fix for Bug #754531
See bug thread for more info about the changes

To post a comment you must log in.
Revision history for this message
Damon Lynch (dlynch3) wrote :

Thank you for your work. The code has some errors but I'll clean them up.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'rapid/generatename.py'
2--- rapid/generatename.py 2011-05-20 01:26:59 +0000
3+++ rapid/generatename.py 2011-10-06 19:03:23 +0000
4@@ -191,12 +191,19 @@
5 v = self.rpd_file.metadata.camera_serial()
6 elif self.L1 == SHUTTER_COUNT:
7 v = self.rpd_file.metadata.shutter_count()
8- if v:
9- v = int(v)
10- padding = LIST_SHUTTER_COUNT_L2.index(self.L2) + 3
11- formatter = '%0' + str(padding) + "i"
12- v = formatter % v
13-
14+ if self.L2 in [ SUBFOLDER_SEQ_NUMBER, STORED_SEQ_NUMBER ] :
15+ if self.L2 == SUBFOLDER_SEQ_NUMBER :
16+ v = str(v)
17+ v = v[:-4]
18+ if self.L2 == STORED_SEQ_NUMBER :
19+ v = str(v)
20+ v = v[-4:]
21+ else:
22+ if v:
23+ v = int(v)
24+ padding = LIST_SHUTTER_COUNT_L2.index(self.L2) + 3
25+ formatter = '%0' + str(padding) + "i"
26+ v = formatter % v
27 elif self.L1 == OWNER_NAME:
28 v = self.rpd_file.metadata.owner_name()
29 elif self.L1 == ARTIST:
30
31=== modified file 'rapid/generatenameconfig.py'
32--- rapid/generatenameconfig.py 2011-05-19 05:02:37 +0000
33+++ rapid/generatenameconfig.py 2011-10-06 19:03:23 +0000
34@@ -311,6 +311,8 @@
35 SEQUENCE_NUMBER_4,
36 SEQUENCE_NUMBER_5,
37 SEQUENCE_NUMBER_6,
38+ SUBFOLDER_SEQ_NUMBER,
39+ STORED_SEQ_NUMBER,
40 ]
41
42 # Level 1
43
44=== modified file 'rapid/metadataphoto.py' (properties changed: +x to -x)
45--- rapid/metadataphoto.py 2011-05-19 05:02:37 +0000
46+++ rapid/metadataphoto.py 2011-10-06 19:03:23 +0000
47@@ -201,6 +201,16 @@
48 keys = self.exif_keys
49 if 'Exif.Nikon3.ShutterCount' in keys:
50 v = self['Exif.Nikon3.ShutterCount'].raw_value
51+ elif 'Exif.CanonFi.FileNumber' in keys:
52+ if self["Exif.Image.Model"].value.strip() == "Canon EOS 400D DIGITAL":
53+ v = self['Exif.CanonFi.FileNumber'].raw_value
54+ v = int(v)
55+ d = (v & 0xffc00) >> 10
56+ while d < 100:
57+ d += 0x40
58+ v = d*10000 + ((v & 0x3ff ) << 4 ) + ((v >> 20) & 0x0f)
59+ else:
60+ v = self['Exif.CanonFi.FileNumber'].raw_value
61 elif 'Exif.Canon.FileNumber' in keys:
62 v = self['Exif.Canon.FileNumber'].raw_value
63 elif 'Exif.Canon.ImageNumber' in keys:

Subscribers

People subscribed via source and target branches

to all changes:
to status/vote changes: