lp:~dylanmccall/update-manager/dialogs-refactor

Created by Dylan McCall and last modified

This was my fix for bug #1111768, but it ended up ballooning into a larger set of changes. Previously, updates would remain visible after clicking Settings and disabling a source, leading to some unexpected (and ugly) situations. In addressing the problem, I found that the architecture around UpdateManager.py was very loopy so I did some work to clean that up. In particular, the Dialog class is now a proper widget, things that used to simply look like Dialogs will now _be_ Dialogs, and dialogs no longer add themselves to the main window: the main window adds them. I'm hoping that this will resolve certain layout issues we have been experiencing, as well as flickering that was caused by my earlier quick fix.

There are some minor visual changes. Screenshots of either version are listed here: http://people.ubuntu.com/~dylanmccall/screenshots/update-manager/bug-1111768/

Get this branch:
bzr branch lp:~dylanmccall/update-manager/dialogs-refactor
Only Dylan McCall can upload to this branch. If you are Dylan McCall please log in for upload directions.

Branch merges

Related bugs

Related blueprints

Branch information

Owner:
Dylan McCall
Project:
Software Updater
Status:
Merged

Recent revisions

2637. By Dylan McCall

Progress dialog is resizable while downloading packages, too.

2636. By Dylan McCall

Fix packaging and pot files.
Put back the 6px margin above header label in each dialog.

2635. By Dylan McCall

Removed unnecessary layout changes in InstallBackendAptdaemon. Progress dialog should not wiggle when it first appears, now.

2634. By Dylan McCall

Put back the "backend" module. It wasn't necessary to move it in this branch.

2633. By Dylan McCall

Removed unnecessary resizing of main window during _start_pane.
Install backends now correctly report when they are cancelled.
Removed unnecessary _on_realize method in UpdatesAvailable, and moved its contents to UpdatesAvailable.start, where they make more sense.
Changed labels in Dialog.ui to remain hidden after show_all, and removed spacing in favour of internal padding, which works better with hidden elements.

2632. By Dylan McCall

Removing ill-advised WrapLabel widget. Restored original behaviour for text wrapping in heading and description labels.

2631. By Dylan McCall

Fixed format for import statements in InstallBackendSynaptic.py

2630. By Dylan McCall

Fixed broken close buttons and certain dialogs failing to initialize.

2629. By Dylan McCall

Every GUI component is now a Dialog subclass, inserted as a widget into the main window, by the main window.
Moved functionality from UpdateProgress and InstallProgress into InstallBackend subclasses and UpdateManager.
Moved functionality from SimpleGtkBuilderApp to BuilderDialog.

2628. By Dylan McCall

Fixed Updates Available dialog flickering when shown.

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
Stacked on:
lp:update-manager
This branch contains Public information 
Everyone can see this information.

Subscribers