lp:~dylanmccall/harvest/opportunity-edit

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:harvest at revision 235

Daniel Holbach: Approve on 2010-08-13

Diff: 1060 lines (+437/-183)

26 files modified

EXTERNALS (+4/-0)
harvest/common/templatetags/humanize_timediff.py (+51/-0)
harvest/common/templatetags/list_to_columns.py (+0/-30)
harvest/media/css/style.css (+113/-30)
harvest/media/js/harvest.js (+10/-8)
harvest/opportunities/admin.py (+8/-2)
harvest/opportunities/forms.py (+6/-2)
harvest/opportunities/models.py (+19/-6)
harvest/opportunities/urls.py (+24/-8)
harvest/opportunities/views.py (+91/-60)
harvest/templates/base.html (+2/-2)
harvest/templates/one_column.html (+9/-0)
harvest/templates/opportunities/filter.html (+1/-1)
harvest/templates/opportunities/include/filter_results.html (+1/-1)
harvest/templates/opportunities/include/opportunity.html (+2/-4)
harvest/templates/opportunities/include/opportunity_details.html (+7/-0)
harvest/templates/opportunities/include/opportunity_details_edit.html (+48/-0)
harvest/templates/opportunities/include/opportunity_li.html (+3/-0)
harvest/templates/opportunities/include/opportunity_notes_list.html (+9/-0)
harvest/templates/opportunities/include/opportunity_outer_li.html (+3/-0)
harvest/templates/opportunities/include/package_details.html (+1/-3)
harvest/templates/opportunities/opportunity_edit.html (+11/-14)
harvest/templates/opportunities/single_package.html (+5/-12)
harvest/templates/opportunities/xhr/opportunity_edit.html (+3/-0)
harvest/templates/opportunities/xhr/opportunity_li.html (+3/-0)
harvest/templates/opportunities/xhr/opportunity_outer_li.html (+3/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

244. By Dylan McCall on 2010-08-13

Fixed wrapping for .opportunity-details.edit > form > ul.opportunity-switches

243. By Dylan McCall on 2010-08-13

Improved formatting for form errors and #messages.

Fixed some inconsistency with padding and margins around elements.

242. By Dylan McCall on 2010-08-12

Edit form now displays errors and current value for new_note

241. By Dylan McCall on 2010-08-12

Reverted XHR changes for opportunity editing in harvest.js, but leaving the plumbing in place.
Saving that for another branch.

Form now validates with new_note field empty.

240. By Dylan McCall on 2010-08-12

Hooked templates up to new Opportunity Notes stuff.

Added new_note form field, which is processed under views.py
.signature elements for notes are no longer floated to the right.

Added and applied humanize_timediff template filter, which outputs something like the built in timediff, but simpler.
Removed unused list_to_columns.py filter.

239. By Dylan McCall on 2010-08-11

Opportunity edit form is now loaded via XHR. (Currently broken beyond that).
Support for opportunity list item to be loaded via XHR.

Changed data-results-packageid attribute to data-package-id

Major schema change: Support for multiple Notes attached to opportunities.
A note has a short bit of text, author and date.

238. By Dylan McCall on 2010-08-06

Added urls, views and templates for xhr with opportunities.

Added /$ to the end of each url under /opportunities to fix some glitches.
Removed URL names that will never be used.
URLs for xhr stuff are now stored as constants in harvest.js.

Moved around functions in views.py to be in a more readable order. (Sorry, this diff is getting pretty huge).

237. By Dylan McCall on 2010-08-06

Background colour for opportunity-details in edit mode only appears when displayed as one in a list.
As a single opportunity, it is not displayed.

Fixed oddly behaved link targets.

236. By Dylan McCall on 2010-08-06

New one_column class and some style changes to accompany it.
The single_package and opportunity_edit pages should look a little more natural now.

235. By Dylan McCall on 2010-08-06

New template for opportunity edit form. Should be fully functional except for notes.

New label for opportunity.experience: "Difficulty".
Opportunity experience choice names are now translatable.

Opportunity details split into a separate include.

Fixed some aggressively specific CSS rules so they are a bit more flexible (as logic dictates).
Added a pagetitle style and applied as appropriate to single_package.html and opportunity_edit.html.