Merge lp:~dylanmccall/harvest/opportunity-description-class into lp:harvest

Proposed by Dylan McCall
Status: Merged
Merged at revision: 311
Proposed branch: lp:~dylanmccall/harvest/opportunity-description-class
Merge into: lp:harvest
Diff against target: 33 lines (+3/-6)
2 files modified
harvest/media/css/opportunities.css (+1/-4)
harvest/templates/opportunities/include/opportunity.html (+2/-2)
To merge this branch: bzr merge lp:~dylanmccall/harvest/opportunity-description-class
Reviewer Review Type Date Requested Status
Daniel Holbach Approve
Review via email: mp+66927@code.launchpad.net

Description of the change

Branch lp:~dholbach/harvest/734746 added an opportunity-long-description class as an alternative to the opportunity-description class, which added some complexity to matching in opportunities.css. This branch adds one more class — opportunity-short-description — and makes opportunity-description go in addition to one of those. This removes some complexity from our CSS file and will hopefully make somebody's life easier in the future :)

To post a comment you must log in.
Revision history for this message
Daniel Holbach (dholbach) wrote :

Much saner approach, yes. :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'harvest/media/css/opportunities.css'
2--- harvest/media/css/opportunities.css 2011-06-28 14:11:37 +0000
3+++ harvest/media/css/opportunities.css 2011-07-05 16:27:30 +0000
4@@ -268,12 +268,9 @@
5 line-height:1em;
6 }
7 .opportunity[data-opportunity-irrelevant] > .opportunity-header > .opportunity-description,
8-.opportunity[data-opportunity-irrelevant] > .opportunity-header > .opportunity-long-description,
9-.opportunity[data-opportunity-applied] > .opportunity-header > .opportunity-description,
10-.opportunity[data-opportunity-applied] > .opportunity-header > .opportunity-long-description {
11+.opportunity[data-opportunity-applied] > .opportunity-header > .opportunity-description, {
12 text-decoration:line-through;
13 }
14-.opportunity-header > a.opportunity-long-description,
15 .opportunity-header > a.opportunity-description {
16 color:#000000;
17 font-size:16px;
18
19=== modified file 'harvest/templates/opportunities/include/opportunity.html'
20--- harvest/templates/opportunities/include/opportunity.html 2011-06-28 14:11:37 +0000
21+++ harvest/templates/opportunities/include/opportunity.html 2011-07-05 16:27:30 +0000
22@@ -2,9 +2,9 @@
23
24 <div class="opportunity-header">
25 {% if opportunity.long_description %}
26- <a href="{{opportunity.url}}" class="opportunity-long-description" target="_blank">{{ opportunity.long_description }}</a>
27+ <a href="{{opportunity.url}}" class="opportunity-description opportunity-long-description" target="_blank">{{ opportunity.long_description }}</a>
28 {% else %}
29- <a href="{{opportunity.url}}" class="opportunity-description" target="_blank">{{ opportunity.description }}</a>
30+ <a href="{{opportunity.url}}" class="opportunity-description opportunity-short-description" target="_blank">{{ opportunity.description }}</a>
31 {% endif %}
32 <span class="actions">
33 {% if user.is_authenticated %}

Subscribers

People subscribed via source and target branches

to all changes: