Merge lp:~dylanmccall/harvest/658910 into lp:harvest

Proposed by Dylan McCall
Status: Merged
Merged at revision: 269
Proposed branch: lp:~dylanmccall/harvest/658910
Merge into: lp:harvest
Diff against target: 120 lines (+14/-19)
2 files modified
harvest/media/css/style.css (+13/-18)
harvest/templates/index.html (+1/-1)
To merge this branch: bzr merge lp:~dylanmccall/harvest/658910
Reviewer Review Type Date Requested Status
Daniel Holbach Approve
Review via email: mp+38177@code.launchpad.net

Description of the change

Okay, it's all fixed up. Design changes are funny things, so feel free to share opinions as well as point out my technical wrongdoings :)

Screenshots are up at http://people.ubuntu.com/~dylanmccall/harvest/bugs/lp658910/

To post a comment you must log in.
Revision history for this message
Daniel Holbach (dholbach) wrote :

Good work!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'harvest/media/css/style.css'
2--- harvest/media/css/style.css 2010-10-05 15:27:43 +0000
3+++ harvest/media/css/style.css 2010-10-12 03:09:44 +0000
4@@ -136,11 +136,11 @@
5 }
6
7 .sectiontitle {
8- margin-bottom:8px;
9 max-width:30em;
10 letter-spacing:-0.1em;
11 font-size:24px;
12- line-height:28px;
13+ margin-bottom:12px;
14+ color:rgb(80,80,80);
15 }
16
17 #content > .one_column {
18@@ -149,10 +149,6 @@
19
20
21
22-#content_welcome .sectiontitle {
23- /* de-emphasize these titles for the more complex page */
24- color:rgb(80,80,80);
25-}
26
27 #content_welcome > #start {
28 display:table-cell;
29@@ -195,10 +191,11 @@
30 font-style:italic;
31 }
32
33-#content_welcome > #faq {
34+#content_welcome #faq {
35 display:table-cell;
36 width:430px;
37 min-width:430px;
38+ color:rgb(80,80,80);
39 }
40
41 #faq > div {
42@@ -213,7 +210,6 @@
43 #faq .question {
44 font-weight:bold;
45 font-style:italic;
46- color:rgb(180,180,180);
47 }
48
49
50@@ -288,17 +284,18 @@
51 margin-bottom:4em;
52 }
53 #filters > .filtergroup > .filter-label {
54+ /* titles for groups of filters ("Packages" and "Opportunities") */
55 display:block;
56- margin-bottom:.5em;
57- color:rgb(0,0,0);
58- font-size:14px;
59- font-weight:bold;
60+ margin-bottom:8px;
61+ letter-spacing:-0.1em;
62+ color:rgb(80,80,80);
63+ font-size:16px;
64 }
65 #filters > .filtergroup > .filter-value > ul {
66 margin-left:0px;
67 }
68 #filters > .filtergroup > .filter-value > ul > li {
69- padding-bottom:5px;
70+ margin-bottom:5px;
71 }
72
73 #filters > .filtergroup > .filter-value > ul > li a.help {
74@@ -449,7 +446,7 @@
75
76 .opportunity-list > .opportunity-list-title {
77 display:block;
78- color:rgb(80, 80, 80);
79+ color:rgb(80,80,80);
80 font-size:12px;
81 letter-spacing:-0.1em;
82 }
83@@ -524,8 +521,6 @@
84 display:block;
85 width:100%;
86 max-width:35em;
87- border-left:dashed 1px rgb(180,180,180);
88- padding:0px 5px;
89 font-size:12px;
90 line-height:1em;
91 }
92@@ -534,13 +529,13 @@
93 border:none;
94 border-bottom:1px solid rgb(180,180,180);
95
96- padding:2px 5px 2px 5px;
97+ padding:2px 5px;
98 background-color:inherit;
99 color:inherit;
100 font:inherit;
101 }
102 .opportunity-notes > ul {
103- margin:0.5em 0;
104+ margin:10px 5px;
105 max-height:10em;
106 }
107 .opportunity-notes > ul > li {
108
109=== modified file 'harvest/templates/index.html'
110--- harvest/templates/index.html 2010-08-31 19:05:02 +0000
111+++ harvest/templates/index.html 2010-10-12 03:09:44 +0000
112@@ -57,7 +57,7 @@
113
114 <li>
115 <span class="question">{% trans "I found a bug. What do I do?" %}</span>
116- <p>{% blocktrans %}If it's about the UI or the functionality of the site, please file a bug on <a href="http://bugs.launchpad.net/harvest/+filebug">harvest</a> in Launchpad. If it's about some piece of data in Harvest, it's likely a script that fetches it. In that case, please file your bug on <a href="https://bugs.launchpad.net/harvest-data/+filebug">harvest-data</a> instead. The <a href="http://bazaar.launchpad.net/~harvest-dev/harvest/trunk/annotate/head:/HACKING">hacking guide</a> explains more.{% endblocktrans %}</p>
117+ <p>{% blocktrans %}If it's about the UI or the functionality of the site, please file a bug on <a href="http://bugs.launchpad.net/harvest/+filebug">harvest</a> in Launchpad. If it's about some piece of data in Harvest, it's likely a script that fetches it. In that case, please file your bug on <a href="http://bugs.launchpad.net/harvest-data/+filebug">harvest-data</a> instead. The <a href="http://bazaar.launchpad.net/~harvest-dev/harvest/trunk/annotate/head:/HACKING">hacking guide</a> explains more.{% endblocktrans %}</p>
118 </li>
119 </ul>
120 </div>

Subscribers

People subscribed via source and target branches

to all changes: