Merge lp:~dyams/unity-2d/toggling-dash-maximize into lp:unity-2d

[Lohith D Shivamurthy]

[Dash] clicking maximize button should toggle the Dash between maximize and unmaximize state

[Lohith D Shivamurthy (dyams)]

Change description in detail:

Now Dash has window buttons (close, minimize & maximize) in the panel.
Maximize button maximizes the dash properly but un-maximize doesn't work.
When the original MR was approved there was not issue like this.
Only after integration i have noticed this problem.
So this patch should solve that dash un-maximize issue.

[Tiago Salem Herrmann (tiagosh)]

It works fine.

review: Approve

[Unity Merger (unity-merger)]

The Jenkins job https://jenkins.qa.ubuntu.com/job/automerge-unity-2d/17/console reported an error when processing this lp:~dyams/unity-2d/toggling-dash-maximize branch.
Not merging it.

[Gerry Boland (gerboland)]

Merge failed due to libdee ABI change breaking our tests. Re-approving

=== modified file 'panel/applets/appname/windowhelper.cpp'
--- panel/applets/appname/windowhelper.cpp	2011-10-17 12:46:55 +0000
+++ panel/applets/appname/windowhelper.cpp	2011-12-02 04:26:23 +0000
@@ -171,7 +171,7 @@
         wnck_window_get_geometry(d->m_window, &x, &y, &width, &height);
         const QRect windowGeometry(x, y, width, height);
         ScreenInfo* screenInfo = ScreenInfo::instance();
-        return screenInfo->availableGeometry() == windowGeometry;
+        return screenInfo->panelsFreeGeometry() == windowGeometry;
     } else {
         return wnck_window_is_maximized(d->m_window);
     }