Merge lp:~dyams/unity-2d/super-plus-keypad-key-enabled into lp:unity-2d
Proposed by
Lohith D Shivamurthy
Status: | Rejected |
---|---|
Rejected by: | Gerry Boland |
Proposed branch: | lp:~dyams/unity-2d/super-plus-keypad-key-enabled |
Merge into: | lp:unity-2d |
Diff against target: |
206 lines (+75/-33) 5 files modified
launcher/app/launcherview.cpp (+43/-11) libunity-2d-private/src/hotkey.cpp (+24/-18) libunity-2d-private/src/hotkey.h (+5/-1) libunity-2d-private/src/hotkeymonitor.cpp (+2/-2) libunity-2d-private/src/hotkeymonitor.h (+1/-1) |
To merge this branch: | bzr merge lp:~dyams/unity-2d/super-plus-keypad-key-enabled |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Gerry Boland (community) | Disapprove | ||
Florian Boucault (community) | Needs Fixing | ||
Review via email:
|
Description of the change
Qt won't distinguish between keys[0-9] below the Function-keys and keys[0-9] on the keypad.
X11 has separate keycodes for them.
You may be interested to check <X11/keysymdef.h>
To post a comment you must log in.
Unmerged revisions
- 784. By Lohith D Shivamurthy
-
[launcher] Tests added
- 783. By Lohith D Shivamurthy
-
[launcher] {super-key + numbers on the keypad} combination is enabled to show/launch the window selected
The merge request misses a 'description'.