Merge lp:~dyams/unity-2d/super-key-position-launcher into lp:unity-2d

Proposed by Lohith D Shivamurthy
Status: Merged
Approved by: Gerry Boland
Approved revision: 789
Merged at revision: 791
Proposed branch: lp:~dyams/unity-2d/super-key-position-launcher
Merge into: lp:unity-2d
Diff against target: 53 lines (+17/-0)
3 files modified
launcher/Launcher.qml (+5/-0)
launcher/app/launcherview.cpp (+9/-0)
launcher/app/launcherview.h (+3/-0)
To merge this branch: bzr merge lp:~dyams/unity-2d/super-key-position-launcher
Reviewer Review Type Date Requested Status
Gerry Boland Pending
Review via email: mp+83145@code.launchpad.net

Commit message

[launcher] Force the launcher to reposition to the beginning when Dash is summoned with Super key

Description of the change

Have the launcher to reposition to the beginning when Dash is summoned with Super key

To post a comment you must log in.
Revision history for this message
Gerry Boland (gerboland) wrote :

Looks great! Please just add test case to https://wiki.ubuntu.com/Unity2DRegressionTests:

- Launcher visible, scrolled down, hit Super. Launcher should hide tooltips/menus, reposition to start.

Revision history for this message
Lohith D Shivamurthy (dyams) wrote :

> Looks great! Please just add test case to
> https://wiki.ubuntu.com/Unity2DRegressionTests:
Thank you, the wiki is updated.

>
> - Launcher visible, scrolled down, hit Super. Launcher should hide
> tooltips/menus, reposition to start.
Yes

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'launcher/Launcher.qml'
2--- launcher/Launcher.qml 2011-11-09 10:30:28 +0000
3+++ launcher/Launcher.qml 2011-11-23 12:21:26 +0000
4@@ -37,6 +37,11 @@
5 }
6 }
7
8+ function positionAtBeginning() {
9+ main.positionViewAtBeginning()
10+ hideMenu()
11+ }
12+
13 GnomeBackground {
14 Accessible.name: "background"
15 anchors.fill: parent
16
17=== modified file 'launcher/app/launcherview.cpp'
18--- launcher/app/launcherview.cpp 2011-11-18 10:15:49 +0000
19+++ launcher/app/launcherview.cpp 2011-11-23 12:21:26 +0000
20@@ -263,6 +263,7 @@
21 }
22
23 dashInterface.asyncCall(DASH_DBUS_METHOD_ACTIVATE_HOME);
24+ positionAtBeginning();
25 }
26 }
27
28@@ -280,3 +281,11 @@
29 QGraphicsObject* launcher = rootObject();
30 QMetaObject::invokeMethod(launcher, "hideMenu", Qt::AutoConnection);
31 }
32+
33+void
34+LauncherView::positionAtBeginning()
35+{
36+ QGraphicsObject* launcher = rootObject();
37+ QMetaObject::invokeMethod(launcher, "positionAtBeginning", Qt::AutoConnection);
38+}
39+
40
41=== modified file 'launcher/app/launcherview.h'
42--- launcher/app/launcherview.h 2011-11-18 10:15:49 +0000
43+++ launcher/app/launcherview.h 2011-11-23 12:21:26 +0000
44@@ -66,6 +66,9 @@
45 void focusOutEvent(QFocusEvent* event);
46
47 private:
48+ void positionAtBeginning();
49+
50+private:
51 bool m_superKeyPressed;
52 bool m_superKeyHeld;
53 bool m_superPressIgnored;

Subscribers

People subscribed via source and target branches