Merge ~dviererbe/ubuntu/+source/m2crypto:ubuntu/devel into ubuntu/+source/m2crypto:ubuntu/devel

Proposed by Dominik Viererbe
Status: Needs review
Proposed branch: ~dviererbe/ubuntu/+source/m2crypto:ubuntu/devel
Merge into: ubuntu/+source/m2crypto:ubuntu/devel
Diff against target: 84 lines (+52/-1)
4 files modified
debian/changelog (+6/-0)
debian/control (+2/-1)
debian/patches/check-for-time_t-64-bits.patch (+43/-0)
debian/patches/series (+1/-0)
Reviewer Review Type Date Requested Status
Graham Inggs (community) Needs Information
Review via email: mp+497509@code.launchpad.net

Description of the change

m2crypto FTBFS on reolute for armhf, because the upstream version 0.43 introduced a test to check for 32-bit time_t [1]. Debian added upstream version 0.46 in unstable.

This MP changes the test to check for 64-bit time_t, because the time_t transition in noble changed the behavior to always return 64_bit time_t timestamp.

[1] https://git.launchpad.net/ubuntu/+source/m2crypto/tree/CHANGES?id=f792a58978997c2357edbadb4b0dbf5fa5c828d5#n80

To post a comment you must log in.
Revision history for this message
Dominik Viererbe (dviererbe) wrote (last edit ):
Revision history for this message
Graham Inggs (ginggs) wrote :

The FTBFS was fixed in m2crypto 0.46.2-2, but the autopkgtest is failing on armhf.

Does your patch ifx the autopkgtest?

review: Needs Information

Unmerged commits

9e1d225... by Dominik Viererbe

changelog

56ac5aa... by Dominik Viererbe

update-maintainer

fc7c26a... by Dominik Viererbe

d/p/check-for-time_t-64-bits.patch: check for 64-bit time_t (LP: #2136110)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 92a5085..f143374 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,9 @@
6+m2crypto (0.46.2-1ubuntu1) resolute; urgency=medium
7+
8+ * d/p/check-for-time_t-64-bits.patch: check for 64-bit time_t (LP: #2136110)
9+
10+ -- Dominik Viererbe <dominik.viererbe@canonical.com> Mon, 15 Dec 2025 12:22:48 +0200
11+
12 m2crypto (0.46.2-1) unstable; urgency=medium
13
14 * Team upload.
15diff --git a/debian/control b/debian/control
16index 072db32..5f83988 100644
17--- a/debian/control
18+++ b/debian/control
19@@ -1,7 +1,8 @@
20 Source: m2crypto
21 Section: python
22 Priority: optional
23-Maintainer: Debian Python Team <team+python@tracker.debian.org>
24+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
25+XSBC-Original-Maintainer: Debian Python Team <team+python@tracker.debian.org>
26 Uploaders:
27 Alexandre Detiste <tchet@debian.org>,
28 Build-Depends:
29diff --git a/debian/patches/check-for-time_t-64-bits.patch b/debian/patches/check-for-time_t-64-bits.patch
30new file mode 100644
31index 0000000..d6a6260
32--- /dev/null
33+++ b/debian/patches/check-for-time_t-64-bits.patch
34@@ -0,0 +1,43 @@
35+Description: Check for 64-bit time_t
36+ Since the 64-bit time_t transition introduced with Ubuntu 24.04 LTS
37+ the time_t timestamp should always be 64 bits in size.
38+Author: Dominik Viererbe <dominik.viererbe@canonical.com>, Ujjwal Sarswat <ujjwal.sarswat@canonical.com>
39+Origin: vendor
40+Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/m2crypto/+bug/2136110
41+Forwarded: not-needed
42+Last-Update: 2025-12-15
43+---
44+This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
45+diff --git a/tests/test_util.py b/tests/test_util.py
46+index e925d03..c7f89e4 100644
47+--- a/tests/test_util.py
48++++ b/tests/test_util.py
49+@@ -14,22 +14,12 @@ from tests import unittest
50+
51+ class UtilTestCase(unittest.TestCase):
52+
53+- def test_is32bit(self):
54+- # defaults
55+- bit32 = m2.time_t_bits()
56+- # test for libc musl from unfinished upstream bug gh#python/cpython#87414
57+- if (
58+- util.is_32bit()
59+- and (platform.libc_ver() != ("", ""))
60+- and (
61+- os.environ.get("M2_TIMET_NO_ARCH", "").casefold()
62+- not in ["true", "1", "yes"]
63+- )
64+- ):
65+- self.assertEqual(bit32, 32)
66+- else:
67+- self.assertNotEqual(bit32, 32)
68+- self.assertIsInstance(bit32, int)
69++ # Since the 64-bit time_t transition introduced with Ubuntu 24.04 LTS
70++ # the time_t timestamp should always be 64 bits in size.
71++ def test_is64bit(self):
72++ bit64 = m2.time_t_bits()
73++ self.assertEqual(bit64, 64)
74++ self.assertIsInstance(bit64, int)
75+
76+
77+ def suite():
78diff --git a/debian/patches/series b/debian/patches/series
79new file mode 100644
80index 0000000..179abe7
81--- /dev/null
82+++ b/debian/patches/series
83@@ -0,0 +1 @@
84+check-for-time_t-64-bits.patch

Subscribers

People subscribed via source and target branches