Merge ~dviererbe/ubuntu/+source/inetutils:ubuntu/devel into ubuntu/+source/inetutils:ubuntu/devel

[Dominik Viererbe]

Remove inetutils-ping package (LP: #2009814)

 * debian/{control,rules}: removed ping/ping6 build config
 * debian/tests/{control,test-root-commands}: disabled ping/ping6
   testing config
 * deleted declarative install files and man pages:
   - debian/inetutils-ping.{install,lintian-overrides,manpages}
   - debian/local/man/{ping,ping6}.1

See: https://launchpad.net/bugs/2009814

[Lukas Märdian (slyon)]

Thanks, this lgtm overall!

A few nitpick comments:

* The git commit message tries to mimic the commit messages synthesized by git-ubuntu importer. Let's just have clean commit messages, containing one single logical change per commit. E.g. one "Update changelog", one "Update maintainer", one "debian/{control,rules}: removed ping/ping6 build config", one "debian/tests/{control,test-root-commands}: disabled ping/ping6 testing", etc.

If the uploader/sponsor does a git-ubuntu compatible upload, those clean commit history will be preserved. If a classic upload is done, a commit message will be synthesized on import.

* Let's try to keep line length in d/changelog <= 80 chars, especially this line:
"* debian/tests/{control,test-root-commands}: disabled ping/ping6 testing"

* Thanks for providing a PPA with test-builds of this change! If you could also provide logs of your successful autopkgtest run, that'd be fantastic!

+1 I'm happy to sponsor this once FFe is granted by the release team.

review: Approve

[Dominik Viererbe (dviererbe)]

@slyon I attached the autopkgtest output to the FFe bug-ticket (See https://bugs.launchpad.net/ubuntu/+source/inetutils/+bug/2009814/comments/7)

Please note that I don't have the capability to build riscv64 in my PPA, but I don't see a reason why this should fail with all the other architectures building fine.

Thanks that I was allowed to do this MIR. I learned so much more than just by reading documentation.

9cdc88d... by Dominik Viererbe on 2023-03-23

d/changelog: add entry for disabled ping tests

f7d3fc4... by Dominik Viererbe on 2023-03-23

d/control: update-maintainer

[Dominik Viererbe (dviererbe)]

I pushed the changes that only disable the tests, but not the build of inetutils-ping.
See: https://bugs.launchpad.net/ubuntu/+source/inetutils/+bug/2009814/comments/8

[Lukas Märdian (slyon)]

Thanks! This change set is even smaller, LGTM!

review: Approve

diff --git a/debian/changelog b/debian/changelog
index d9974ef..7ce0b02 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,9 @@
+inetutils (2:2.4-2ubuntu1) lunar; urgency=medium
+
+  * Do not test the inetutils-ping package (LP: #2009814)
+
+ -- Dominik Viererbe <[e-mail]>  Thu, 23 Mar 2023 11:32:35 +0200
+
 inetutils (2:2.4-2) unstable; urgency=medium
 
   * Add support for new RFC4443 ICMPv6 destination unreachable codes.
diff --git a/debian/control b/debian/control
index 62d9d77..da3fb08 100644
--- a/debian/control
+++ b/debian/control
@@ -1,7 +1,8 @@
 Source: inetutils
 Section: net
 Priority: optional
-Maintainer: Guillem Jover <[e-mail]>
+Maintainer: Ubuntu Developers <[e-mail]>
+XSBC-Original-Maintainer: Guillem Jover <[e-mail]>
 Vcs-Browser: https://git.hadrons.org/cgit/debian/pkgs/inetutils.git
 Vcs-Git: https://git.hadrons.org/git/debian/pkgs/inetutils.git
 Homepage: https://www.gnu.org/software/inetutils/
diff --git a/debian/tests/control b/debian/tests/control
index fa56d30..f53a210 100644
--- a/debian/tests/control
+++ b/debian/tests/control
@@ -28,7 +28,6 @@ Depends:
  net-tools,
  inetutils-ftp,
  inetutils-ftpd,
- inetutils-ping,
  inetutils-traceroute,
 Restrictions:
  allow-stderr
diff --git a/debian/tests/test-root-commands b/debian/tests/test-root-commands
index 1fa1530..3244559 100755
--- a/debian/tests/test-root-commands
+++ b/debian/tests/test-root-commands
@@ -7,10 +7,10 @@ autoreconf -f -i
   --disable-libls \
   --disable-servers \
   --disable-clients \
+  --disable-ping \
+  --disable-ping6 \
   --enable-ftp \
   --enable-ftpd \
-  --enable-ping \
-  --enable-ping6 \
   --enable-traceroute \
   # EOL
 
@@ -20,8 +20,6 @@ export VERBOSE=1
 
 export FTP=$(command -v inetutils-ftp)
 export FTPD=$(command -v ftpd)
-export PING6=$(command -v ping6)
-export PING=$(command -v ping)
 export TRACEROUTE=$(command -v inetutils-traceroute)
 
 make -C lib 2>&1