Merge ~dustymabe/cloud-init:fix-xfs-grow into cloud-init:master

Proposed by Dusty Mabe
Status: Merged
Approved by: Scott Moser
Approved revision: 192cf5dec1b2f8403630613311531ac29c64bb49
Merged at revision: 29a9296cd68516e76d0bd8da320754a222c4ee45
Proposed branch: ~dustymabe/cloud-init:fix-xfs-grow
Merge into: cloud-init:master
Diff against target: 13 lines (+1/-1)
1 file modified
cloudinit/config/cc_resizefs.py (+1/-1)
Reviewer Review Type Date Requested Status
Scott Moser Approve
Review via email: mp+330701@code.launchpad.net

Description of the change

fix xfs_growfs in cloud-init (see commit message for more info)

To post a comment you must log in.
Revision history for this message
Ryan Harper (raharper) wrote :

Hi Dusty,

Thank you for your contribution to cloud-init. Contributions to
cloud-init require the developer to have signed the Canonical Contributors
Agreement [1]. Your launchpad id is not currently listed as a member of
the contributor-agreement-canonical group [2].

Membership in that group is currently managed by a manual process, so it
is possible that you have followed the process but were not added to the
group. If you have already signed the contributor agreement, please
simply say so here.

For more information on contribution see the hacking documentation in
cloud-init [3].

--
[1] https://www.ubuntu.com/legal/contributors
[2] https://launchpad.net/~contributor-agreement-canonical/+members
[3] http://cloudinit.readthedocs.io/en/latest/topics/hacking.html

Revision history for this message
Scott Moser (smoser) wrote :

Thanks for doing the leg work and filing a good RH bug and then
following up here.

I'm going to put this into 'work in progress'. When you've got the
contributors agreement signed just say so and put it back to
'needs review' and we can pull it.

Thanks again,
Scott

review: Approve
Revision history for this message
Dusty Mabe (dustymabe) wrote :

Just signed. Sorry about the delay, had a fire to put out.

Revision history for this message
Scott Moser (smoser) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/cloudinit/config/cc_resizefs.py b/cloudinit/config/cc_resizefs.py
2index ceee952..d78e17f 100644
3--- a/cloudinit/config/cc_resizefs.py
4+++ b/cloudinit/config/cc_resizefs.py
5@@ -54,7 +54,7 @@ def _resize_ext(mount_point, devpth):
6
7
8 def _resize_xfs(mount_point, devpth):
9- return ('xfs_growfs', devpth)
10+ return ('xfs_growfs', mount_point)
11
12
13 def _resize_ufs(mount_point, devpth):

Subscribers

People subscribed via source and target branches