Ubuntu Document Viewer App

Merge lp:~dtrg21/ubuntu-docviewer-app/add-readmes into lp:ubuntu-docviewer-app

  1. add-readmes
  2. Merge into lo-viewer
Proposed by Aditya
Status: Rejected
Rejected by: Stefano Verzegnassi
Proposed branch: lp:~dtrg21/ubuntu-docviewer-app/add-readmes
Merge into: lp:ubuntu-docviewer-app
To merge this branch: bzr merge lp:~dtrg21/ubuntu-docviewer-app/add-readmes
Reviewer Review Type Date Requested Status
Stefano Verzegnassi Disapprove
Andrew Hayzen (community) Abstain
Nicholas Skaggs Pending
Alan Pope 🍺🐧🐱 🦄 Pending
Review via email: mp+281340@code.launchpad.net

Description of the change

Task from Google Code In. Added README's.

To post a comment you must log in.
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

Strange how there is no diff, that can be seen here [0]. Also I'm not that the unit test readme is required as I cannot spot any unit test files in the repo?

I've added the docviewer developers as a reviewer to this MP, so they can decide if it is required as I cannot spot any unittest files.

$ bzr branch lp:ubuntu-docviewer-app
$ cd ubuntu-docviewer-app/
$ find | grep tst
$

0 - http://bazaar.launchpad.net/~dtrg21/ubuntu-docviewer-app/add-readmes/revision/239

review: Abstain
Revision history for this message
Stefano Verzegnassi (verzegnassi-stefano) wrote :

Docviewer has no unit tests yet (bug #1400880), therefore the unit test readme is not required. For now I have to disapprove this MP.

Thanks anyway for spending some time on this!

review: Disapprove

Unmerged revisions

239. By Aditya

Add README's. Task from Google Code In

Subscribers

People subscribed via source and target branches