Thanks for getting this next step up for review! Several things in need
of fixing:


https://codereview.appspot.com/49050044/diff/20001/dependencies.tsv
File dependencies.tsv (right):

https://codereview.appspot.com/49050044/diff/20001/dependencies.tsv#newcode7
dependencies.tsv:7:
launchpad.net/gojoyent	bzr	 
<email address hidden>	47
It seems gojoyent in turn depends on github.com/nu7hatch/gouuid for
tests in localservices/manta/service.go

That would also need adding here - do we want it as a dep or should the
tests just generate sample uuids through some other method?

https://codereview.appspot.com/49050044/diff/20001/provider/joyent/config_test.go
File provider/joyent/config_test.go (right):

https://codereview.appspot.com/49050044/diff/20001/provider/joyent/config_test.go#newcode4
provider/joyent/config_test.go:4: package joyent
What's the reason to change this from external to internal testing?

https://codereview.appspot.com/49050044/diff/20001/provider/joyent/config_test.go#newcode26
provider/joyent/config_test.go:26: "sdc-key-id":
"12:c3:a7:cb:a2:29:e2:90:88:3f:04:53:3b:4e:75:40",
Not changed here, but duplicated later, so mentioning. These fake values
should be faker, rather than being for name and a real-looking key id.
Better to spot in test assertions and such like if it's testuser and
00:11:22:... or similar obvious made up values.

https://codereview.appspot.com/49050044/diff/20001/provider/joyent/joyent_test.go
File provider/joyent/joyent_test.go (right):

https://codereview.appspot.com/49050044/diff/20001/provider/joyent/joyent_test.go#newcode57
provider/joyent/joyent_test.go:57: "sdc-key-id":
"12:c3:a7:cb:a2:29:e2:90:88:3f:04:53:3b:4e:75:40",
These values look very similar to the earlier ones, perhaps they need to
be in a shared location and accessed from there. Otherwise, same comment
applies, user and key-id should be more obviously fake.

https://codereview.appspot.com/49050044/diff/20001/provider/joyent/storage.go
File provider/joyent/storage.go (right):

https://codereview.appspot.com/49050044/diff/20001/provider/joyent/storage.go#newcode83
provider/joyent/storage.go:83: // deleteContainer deletes the named
comtainer from the storage account.
Typo, 'coNtainer'.

https://codereview.appspot.com/49050044/diff/20001/provider/joyent/storage.go#newcode107
provider/joyent/storage.go:107: //return something that a random wget
can retrieve the object at, without any credentials
This may as well be an actual function doc comment.

https://codereview.appspot.com/49050044/diff/20001/provider/joyent/storage.go#newcode109
provider/joyent/storage.go:109: return s.manta.SignURL(path,
time.Now().Add(time.Minute*5))
I think the EC2 provider uses a mcuh longer duration, what a sensible
value is I'm less sure.

https://codereview.appspot.com/49050044/diff/20001/provider/joyent/storage.go#newcode125
provider/joyent/storage.go:125: //obj := r.Read()
Remove.

https://codereview.appspot.com/49050044/diff/20001/provider/joyent/storage.go#newcode141
provider/joyent/storage.go:141: func (s *joyentStorage) RemoveAll()
error {
This is logic I'm not wild about having done (and slightly differently)
in all providers. The openstack version for instance has logic for
limiting the number of concurrent requests...

https://codereview.appspot.com/49050044/diff/20001/provider/joyent/storage_test.go
File provider/joyent/storage_test.go (right):

https://codereview.appspot.com/49050044/diff/20001/provider/joyent/storage_test.go#newcode1
provider/joyent/storage_test.go:1: // Copyright 2013 Joyent Inc.
All the tests in this file bar TestURL fail when I run them here, with
variations on:

FAIL: storage_test.go:140: storageSuite.TestCreateContainer

storage_test.go:143:
     s.assertContainer(mantaStorage, c)
storage_test.go:43:
     c.Assert(err, gc.IsNil)
... value *errors.gojoyentError =
&errors.gojoyentError{error:(*errors.errorString)(0xc2002f33b0),
errcode:"UnkownError", cause:(*errors.gojoyentError)(0xc200304510)}
("failed to create directory: juju-test\ncaused by: Bad request
https://us-east.manta.joyent.com/dstroppa/stor/juju-test\ncaused by:
request (https://us-east.manta.joyent.com/dstroppa/stor/juju-test)
returned unexpected status: 400; error info:
{\"code\":\"InvalidHeader\",\"message\":\"Authorization header invalid:
signature was not specified\"}")

It seems they're escaping isolation, rather than using the test
services?

https://codereview.appspot.com/49050044/