Merge lp:~dsmythies/serverguide/makefile_changes into lp:~ubuntu-core-doc/serverguide/raring
Status: | Merged |
---|---|
Approved by: | Doug Smythies |
Approved revision: | no longer in the source branch. |
Merged at revision: | 118 |
Proposed branch: | lp:~dsmythies/serverguide/makefile_changes |
Merge into: | lp:~ubuntu-core-doc/serverguide/raring |
Diff against target: |
251 lines (+58/-135) 6 files modified
Makefile (+15/-1) serverguide/C/mail.xml (+43/-2) serverguide/sample/posfix_commands.sh (+0/-31) serverguide/sample/postfix_configuration (+0/-40) serverguide/sample/resolv.conf (+0/-5) serverguide/sample/sources.list (+0/-56) |
To merge this branch: | bzr merge lp:~dsmythies/serverguide/makefile_changes |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Doug Smythies | Approve | ||
Review via email: mp+155154@code.launchpad.net |
Description of the change
This MP has changes to the Makefile and mail.xml dealing with LP: #1159144 and LP: #972925.
The serverguide HTML was not centered (at least on some browsers), and the methods used in the desktop documentation were pretty much copied to the serverguide Makefile.
There were obsolete and no longer used files in the sample sub-directory. The one file that was still being used was moved to within <programlisting> tags in-line in mail.xml, and the entire sample sub-directory was removed. Why? Because the PDF document must stand by itself and not have relative links to somewhere that doesn't exist if the PDF has been copied elsewhere.
Note: I have no clue what this line in the Makfile does:
and I have mindlessly copied it from the desktop Makefile. It might be the case that it is not required for the serverguide.
I realize that the more experienced documentation committers that actually know what is going on and the reasons for that way things are (were) have backed off. However I hope that they will review this.
I would be very grateful if someone would review this MP. There will be conflicts (I think) with some coming stuff if not dealt with.
I'll proably wait another day, and then just do it myself, as string freeze is coming and there is still much to do.