Merge lp:~dsas/wxbanker/404347-plural-time-units into lp:wxbanker

Proposed by Dean Sas
Status: Merged
Merged at revision: not available
Proposed branch: lp:~dsas/wxbanker/404347-plural-time-units
Merge into: lp:wxbanker
Diff against target: None lines
To merge this branch: bzr merge lp:~dsas/wxbanker/404347-plural-time-units
Reviewer Review Type Date Requested Status
Michael Rooney Approve
Review via email: mp+9266@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Dean Sas (dsas) wrote :
Revision history for this message
Michael Rooney (mrooney) wrote :

Thanks, this looks good! I didn't know about ngettext or the way to "comment" string formatting; both of these are helpful.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'newtransactionctrl.py'
2--- newtransactionctrl.py 2009-07-06 04:20:17 +0000
3+++ newtransactionctrl.py 2009-07-24 22:45:07 +0000
4@@ -18,6 +18,7 @@
5
6 import wx, datetime
7 import bankcontrols
8+import gettext
9 from wx.lib.pubsub import Publisher
10
11 class RecurringSummaryText(wx.Panel):
12@@ -180,13 +181,10 @@
13 repeatType, every, repeatsOn, end = self.GetSettings()
14 summary = "Summary"
15 if repeatType == 0:
16- everyText = _("days")
17- if every == 1:
18- summary = _("Daily")
19- else:
20- summary = _("Every %i days") % every
21+ everyText = gettext.ngettext("day", "days",every)
22+ summary = gettext.ngettext("Daily", "Every %(num)d days", every) % {'num':every}
23 elif repeatType == 1:
24- everyText = _("weeks")
25+ everyText = gettext.ngettext("week", "weeks", every)
26 self.repeatsOnText.Label = label=_("Repeats on days:")
27 self.Sizer.Show(self.bottomSizer)
28 if repeatsOn == "1,1,1,1,1,0,0":
29@@ -205,17 +203,11 @@
30 else:
31 summary = _("Weekly on %s") % ((", ".join(repeatDays[:-1])) + (_(" and %s") % repeatDays[-1]))
32 elif repeatType == 2:
33- everyText = _("months")
34- if every == 1:
35- summary = _("Monthly")
36- else:
37- summary = _("Every %i months") % every
38+ everyText = gettext.ngettext("month", "months", every)
39+ summary = gettext.ngettext("Monthly", "Every %(num)d months", every) % {'num':every}
40 elif repeatType == 3:
41- everyText = _("years")
42- if every == 1:
43- summary = _("Annually")
44- else:
45- summary = _("Every %i years") % every
46+ everyText = gettext.ngettext("year", "years", every)
47+ summary = gettext.ngettext("Annually", "Every %(num)d years", every) % {'num':every}
48
49 # If the recurring ends at some point, add that information to the summary text.
50 if end:

Subscribers

People subscribed via source and target branches

to all changes: