Merge lp:~droetker/ubuntu/saucy/bumblebee/fix-for-1250745 into lp:ubuntu/saucy/bumblebee

Proposed by Christian González
Status: Rejected
Rejected by: Martin Pitt
Proposed branch: lp:~droetker/ubuntu/saucy/bumblebee/fix-for-1250745
Merge into: lp:ubuntu/saucy/bumblebee
Diff against target: 78 lines (+21/-5)
4 files modified
debian/bumblebee.postinst (+1/-1)
debian/changelog (+15/-0)
debian/control (+4/-3)
debian/rules (+1/-1)
To merge this branch: bzr merge lp:~droetker/ubuntu/saucy/bumblebee/fix-for-1250745
Reviewer Review Type Date Requested Status
Martin Pitt Disapprove
Review via email: mp+194996@code.launchpad.net

Description of the change

removes virtualgl package recommendation

To post a comment you must log in.
Revision history for this message
Martin Pitt (pitti) wrote :

I won't merge this as the alternative recommends: is fine. No need to introduce a delta to Debian for this. Thanks!

review: Disapprove

Unmerged revisions

6. By Christian González

remove non-existent 'virtualgl' recommendation (LP: #1250745)

5. By Vincent Cheng

* Use dh-systemd (for systemd-specific additions to maintscripts).
  (Closes: #715270)
* Add bumblebee group as system group (gid in between 100-999) instead
  of a regular group in postinst. (Closes: #718772)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/bumblebee.postinst'
2--- debian/bumblebee.postinst 2013-05-03 03:04:38 +0000
3+++ debian/bumblebee.postinst 2013-11-13 07:51:09 +0000
4@@ -20,7 +20,7 @@
5 # default group and if the group is missing
6 if grep -qx ServerGroup=$BB_GROUP /etc/bumblebee/bumblebee.conf &&
7 ! getent group $BB_GROUP > /dev/null; then
8- groupadd $BB_GROUP
9+ groupadd --system $BB_GROUP
10 users=$(getent group $USE_GROUPS | cut -d: -f4 | tr , '\n' | sort -u)
11 echo "Adding members from group(s) '$USE_GROUPS' to '$BB_GROUP':"
12 echo $users
13
14=== modified file 'debian/changelog'
15--- debian/changelog 2013-07-11 01:18:07 +0000
16+++ debian/changelog 2013-11-13 07:51:09 +0000
17@@ -1,3 +1,18 @@
18+bumblebee (3.2.1-4ubuntu2) UNRELEASED; urgency=low
19+
20+ * remove non-existent 'virtualgl' recommendation (LP: #1250745)
21+
22+ -- Christian A. Reiter <christian@aragorn> Wed, 13 Nov 2013 08:37:49 +0100
23+
24+bumblebee (3.2.1-4) unstable; urgency=low
25+
26+ * Use dh-systemd (for systemd-specific additions to maintscripts).
27+ (Closes: #715270)
28+ * Add bumblebee group as system group (gid in between 100-999) instead
29+ of a regular group in postinst. (Closes: #718772)
30+
31+ -- Vincent Cheng <Vincentc1208@gmail.com> Tue, 20 Aug 2013 02:35:34 -0700
32+
33 bumblebee (3.2.1-3) unstable; urgency=low
34
35 * Append /usr/lib/primus to CONF_PRIMUS_LD_PATH in d/rules to ease
36
37=== modified file 'debian/control'
38--- debian/control 2013-07-11 01:18:07 +0000
39+++ debian/control 2013-11-13 07:51:09 +0000
40@@ -1,13 +1,14 @@
41 Source: bumblebee
42 Section: utils
43 Priority: extra
44-Maintainer: Debian NVIDIA Maintainers <pkg-nvidia-devel@lists.alioth.debian.org>
45+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
46+XSBC-Original-Maintainer: Debian NVIDIA Maintainers <pkg-nvidia-devel@lists.alioth.debian.org>
47 Uploaders:
48 Aron Xu <aron@debian.org>,
49 Vincent Cheng <Vincentc1208@gmail.com>,
50 Yunqiang Su <wzssyqa@gmail.com>
51 Build-Depends: debhelper (>= 9), libbsd-dev (>= 0.2.0), pkg-config,
52- libx11-dev, libglib2.0-dev, help2man
53+ libx11-dev, libglib2.0-dev, help2man, dh-systemd (>= 1.4)
54 Standards-Version: 3.9.4
55 Homepage: https://launchpad.net/~bumblebee
56 Vcs-Git: git://anonscm.debian.org/pkg-nvidia/bumblebee.git
57@@ -16,7 +17,7 @@
58 Package: bumblebee
59 Architecture: linux-any
60 Depends: ${shlibs:Depends}, ${misc:Depends}, bbswitch-dkms | bbswitch-source
61-Recommends: virtualgl | primus
62+Recommends: primus
63 Suggests: bumblebee-nvidia (= ${binary:Version})
64 Description: NVIDIA Optimus support for Linux
65 Bumblebee is an effort to make NVIDIA Optimus enabled laptops work in
66
67=== modified file 'debian/rules'
68--- debian/rules 2013-07-11 01:18:07 +0000
69+++ debian/rules 2013-11-13 07:51:09 +0000
70@@ -5,7 +5,7 @@
71 #export DH_VERBOSE=1
72
73 %:
74- dh $@
75+ dh $@ --with systemd
76
77 override_dh_auto_configure:
78 # Ubuntu and Debian's packaging of nvidia's proprietary driver differ greatly

Subscribers

People subscribed via source and target branches