Merge lp:~dreis-pt/project-service/7.0-unported-dr into lp:~project-core-editors/project-service/trunk

Proposed by Daniel Reis
Status: Merged
Merged at revision: 30
Proposed branch: lp:~dreis-pt/project-service/7.0-unported-dr
Merge into: lp:~project-core-editors/project-service/trunk
Diff against target: 9 lines (+0/-0)
0 files modified
To merge this branch: bzr merge lp:~dreis-pt/project-service/7.0-unported-dr
Reviewer Review Type Date Requested Status
Pedro Manuel Baeza Approve
Review via email: mp+196288@code.launchpad.net

Description of the change

Moving unported modules to a subdirectory, as per ML discussion.
Modules with pending MPs are kept as is, to avoid merge conflicts.

To post a comment you must log in.
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

Thank you Daniel for starting with this task, but I think that it's mandatory first to update documentation to avoid misunderstandings.

Another thing, have you tried if OpenERP complains about this structure?

Regards.

Revision history for this message
Daniel Reis (dreis-pt) wrote :

Hi Pedro: Just tested that, and ran the "Update modules" menu option without issues.

I don't see why it should be mandatory to wait for the documentation to be updated, if a general agreement has already been reached.

But I do understand it you tell me that we should wait a couple of days to consider the ML discussion as settled...

Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

Hi, Daniel,

Good to know that there is no problem with this change. Although we can wait a little more to proceed, I approve for now the MP.

Regards.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added directory '__unported__'
2=== renamed directory 'base_contract' => '__unported__/base_contract'
3=== renamed directory 'email_template_team_default' => '__unported__/email_template_team_default'
4=== renamed directory 'project_functional_blocks' => '__unported__/project_functional_blocks'
5=== renamed directory 'project_issue_sequences' => '__unported__/project_issue_sequences'
6=== renamed directory 'project_service_base' => '__unported__/project_service_base'
7=== renamed directory 'project_service_contract' => '__unported__/project_service_contract'
8=== renamed directory 'project_service_profiling' => '__unported__/project_service_profiling'
9=== renamed directory 'res_partner_contract' => '__unported__/res_partner_contract'

Subscribers

People subscribed via source and target branches