Merge lp:~dragly/ubuntu-rssreader-app/initial-design into lp:~ubuntu-shorts-dev/ubuntu-rssreader-app/trunk
Status: | Merged |
---|---|
Approved by: | Joey Chan |
Approved revision: | 9 |
Merged at revision: | 6 |
Proposed branch: | lp:~dragly/ubuntu-rssreader-app/initial-design |
Merge into: | lp:~ubuntu-shorts-dev/ubuntu-rssreader-app/trunk |
Diff against target: |
606 lines (+242/-135) 9 files modified
EntryListPage.qml (+12/-28) EntryListTab.qml (+12/-0) FeedListPage.qml (+15/-9) SingleEntryPage.qml (+20/-0) TodayPage.qml (+77/-0) databasemodule.js (+47/-15) rssreader.qmlproject (+1/-1) tabshelper.js (+1/-0) ubuntu-rssreader-app.qml (+57/-82) |
To merge this branch: | bzr merge lp:~dragly/ubuntu-rssreader-app/initial-design |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ubuntu Phone Apps Jenkins Bot | continuous-integration | Approve | |
Ubuntu Shorts Developers | Pending | ||
Review via email: mp+158862@code.launchpad.net |
Commit message
Implemented design proposal with horizontal swipes between feeds on main screen.
Description of the change
Changed the layout of the app to show feeds in tabs in the main view. Sideways scrolling changes feed. Currently no page for "all" feeds - to be added. Very hackish solution to show multiple tabs with auto-generated QML on the fly. Needs upstream fix (see bug #1124071 for details).
The layout is based on a combination of Tabs + PageStack. The topmost element of the stack is the only with tabs (to avoid confusion with the back key on lower levels).
Feed list is accessible from the toolbar icon.
Single feeds may be seen via this menu.
Single entries are shown in a separate page.
Adding feeds is reflected in updated tabs in the main view.
Updated databasemodule.js with function to read feed information. Also removed global dbResult object in favor of functions returning values/objects. (Could possibly be replaced with asynchronous callbacks, but the LocalStorage API is synchronous, so this should not result in any problems.)
FAILED: Continuous integration, rev:9 /code.launchpad .net/~dragly/ ubuntu- rssreader- app/initial- design/ +merge/ 158862/ +edit-commit- message
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https:/
http:// 91.189. 93.125: 8080/job/ ubuntu- rssreader- app-ci/ 7/ 91.189. 93.125: 8080/job/ ubuntu- rssreader- app-quantal- amd64-ci/ 7 91.189. 93.125: 8080/job/ ubuntu- rssreader- app-raring- amd64-ci/ 7
Executed test runs:
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild: 91.189. 93.125: 8080/job/ ubuntu- rssreader- app-ci/ 7/rebuild
http://