Merge lp:~dpm/ubuntuone-client/plurals-fix into lp:ubuntuone-client

Proposed by dobey
Status: Merged
Approved by: dobey
Approved revision: 264
Merged at revision: not available
Proposed branch: lp:~dpm/ubuntuone-client/plurals-fix
Merge into: lp:ubuntuone-client
Diff against target: 30 lines
1 file modified
bin/ubuntuone-client-applet (+3/-3)
To merge this branch: bzr merge lp:~dpm/ubuntuone-client/plurals-fix
Reviewer Review Type Date Requested Status
dobey (community) Approve
Review via email: mp+13710@code.launchpad.net

Commit message

Don't redefine ngettext as P_ but use ngettext instead
Reword one string to be a bit more clear and remain singular

To post a comment you must log in.
Revision history for this message
dobey (dobey) wrote :

Was already approved for merging to my branch, but should have been proposed to merge to trunk.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'bin/ubuntuone-client-applet'
2--- bin/ubuntuone-client-applet 2009-10-14 18:23:35 +0000
3+++ bin/ubuntuone-client-applet 2009-10-21 14:55:19 +0000
4@@ -50,7 +50,7 @@
5 DBusGMainLoop(set_as_default=True)
6
7 _ = gettext.gettext
8-P_ = gettext.ngettext
9+ngettext = gettext.ngettext
10
11 APPLET_BUS_NAME = "com.ubuntuone.ClientApplet"
12 APPLET_CONFIG_NAME = APPLET_BUS_NAME + ".Config"
13@@ -518,7 +518,7 @@
14 def __update_transfer_status(self, done=False):
15 """Update the status display."""
16 with self.__lock:
17- text = _("Updating %(transfers)d of %(total)d files...") % (
18+ text = _("Updating file %(transfers)d of %(total)d...", % (
19 { 'transfers' : self.__updating,
20 'total' : self.__total})
21 label = self.__litems["status"].get_child()
22@@ -582,7 +582,7 @@
23 with self.__lock:
24 n = pynotify.Notification(
25 _("Updating Finished"),
26- P_("Ubuntu One finished updating %(total)d file.",
27+ ngettext("Ubuntu One finished updating %(total)d file.",
28 "Ubuntu One finished updating %(total)d files.",
29 self.__total) % { 'total' : self.__total })
30 self.__total = 0

Subscribers

People subscribed via source and target branches