Merge lp:~dpm/ubuntuone-client/plurals-fix into lp:~dobey/ubuntuone-client/pot-build-fix

Proposed by David Planella
Status: Rejected
Rejected by: dobey
Proposed branch: lp:~dpm/ubuntuone-client/plurals-fix
Merge into: lp:~dobey/ubuntuone-client/pot-build-fix
Diff against target: 30 lines
1 file modified
bin/ubuntuone-client-applet (+3/-3)
To merge this branch: bzr merge lp:~dpm/ubuntuone-client/plurals-fix
Reviewer Review Type Date Requested Status
Guillermo Gonzalez (community) Approve
Tim Cole (community) Approve
Review via email: mp+13660@code.launchpad.net
To post a comment you must log in.
Revision history for this message
David Planella (dpm) wrote :

Fix for bug 456578, after conversation with dobey.

Revision history for this message
Tim Cole (tcole) wrote :

This looks strangely familiar, but looks fine.

review: Approve
Revision history for this message
Guillermo Gonzalez (verterok) wrote :

looks good.

review: Approve

Unmerged revisions

264. By David Planella

Rephrased sentence to make it not necessary to use plurals for translation

263. By David Planella

Fix for extraction of ngettext strings (LP #455527)

Additionally marked another string to use plurals

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'bin/ubuntuone-client-applet'
2--- bin/ubuntuone-client-applet 2009-10-14 18:23:35 +0000
3+++ bin/ubuntuone-client-applet 2009-10-20 19:10:21 +0000
4@@ -50,7 +50,7 @@
5 DBusGMainLoop(set_as_default=True)
6
7 _ = gettext.gettext
8-P_ = gettext.ngettext
9+ngettext = gettext.ngettext
10
11 APPLET_BUS_NAME = "com.ubuntuone.ClientApplet"
12 APPLET_CONFIG_NAME = APPLET_BUS_NAME + ".Config"
13@@ -518,7 +518,7 @@
14 def __update_transfer_status(self, done=False):
15 """Update the status display."""
16 with self.__lock:
17- text = _("Updating %(transfers)d of %(total)d files...") % (
18+ text = _("Updating file %(transfers)d of %(total)d...", % (
19 { 'transfers' : self.__updating,
20 'total' : self.__total})
21 label = self.__litems["status"].get_child()
22@@ -582,7 +582,7 @@
23 with self.__lock:
24 n = pynotify.Notification(
25 _("Updating Finished"),
26- P_("Ubuntu One finished updating %(total)d file.",
27+ ngettext("Ubuntu One finished updating %(total)d file.",
28 "Ubuntu One finished updating %(total)d files.",
29 self.__total) % { 'total' : self.__total })
30 self.__total = 0

Subscribers

People subscribed via source and target branches

to all changes: