Merge lp:~dpm/ubuntu-sso-client/i18n into lp:ubuntu-sso-client
Status: | Rejected | ||||
---|---|---|---|---|---|
Rejected by: | Natalia Bidart | ||||
Proposed branch: | lp:~dpm/ubuntu-sso-client/i18n | ||||
Merge into: | lp:ubuntu-sso-client | ||||
Diff against target: |
293 lines (+74/-44) 6 files modified
bin/ubuntu-sso-login (+10/-11) po/POTFILES.in (+5/-0) setup.py (+9/-1) ubuntu_sso/auth.py (+23/-11) ubuntu_sso/gui.py (+7/-5) ubuntu_sso/keyring.py (+20/-16) |
||||
To merge this branch: | bzr merge lp:~dpm/ubuntu-sso-client/i18n | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
David Planella (community) | Disapprove | ||
Ubuntu One hackers | Pending | ||
Review via email: mp+33107@code.launchpad.net |
Description of the change
This merge proposal adds internationaliz
In order to do this I've adapted setup.py file to use python-
I've checked that translatable strings are extracted correctly and a template is created with './setup.py build_i18n', but I'll leave further testing of the application and the build system to the Ubuntu One team. This patch should give you an idea of what is needed to implement i18n support.
A couple of notes:
* I've set the same translation domain in several places (see gettext.
* I guess the Ubuntu package will need a new dependency on python-
* I've noticed that there is an e-mail screenshot in the code. I'm not sure how this is used, but if it's shown in the UI, that's rather useless for users who don't speak English. Please consider using translatable text instead.
Unmerged revisions
- 578. By David Planella
-
Fixed the whitespace in some strings
- 577. By David Planella
-
Added i18n support and adapted setup.py for python-
distutils- extra usage
After talking with Naty on IRC, she'll be working on this and include some of the changes in a next branch, as some of the files (e.g. auth.py) have now become obsolete very recently.