Merge lp:~dpm/ubuntu-sso-client/i18n-fixes into lp:ubuntu-sso-client

Proposed by David Planella
Status: Merged
Approved by: Rodrigo Moya
Approved revision: 598
Merged at revision: 601
Proposed branch: lp:~dpm/ubuntu-sso-client/i18n-fixes
Merge into: lp:ubuntu-sso-client
Diff against target: 29 lines (+3/-2)
1 file modified
setup.py (+3/-2)
To merge this branch: bzr merge lp:~dpm/ubuntu-sso-client/i18n-fixes
Reviewer Review Type Date Requested Status
Rodrigo Moya (community) Approve
Natalia Bidart (community) Approve
Review via email: mp+33823@code.launchpad.net

Commit message

Make setup.py actually use python-distutils-extra, which will allow the .deb package to build the POT file required to import translations into Launchpad (LP: #624891).

Description of the change

After seeing that after the 0.99.3 package upload translations were imported into Launchpad, I tested the package locally and noticed that there were still changes needed to make the Ubuntu SSO client translatable.

This change makes setup.py actually use python-distutils-extra, which will allow the .deb package to build the POT file required to import translations into Launchpad.

To post a comment you must log in.
Revision history for this message
Natalia Bidart (nataliabidart) :
review: Approve
Revision history for this message
Rodrigo Moya (rodrigo-moya) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'setup.py'
2--- setup.py 2010-08-26 01:01:25 +0000
3+++ setup.py 2010-08-26 19:23:38 +0000
4@@ -21,6 +21,7 @@
5
6 try:
7 import DistUtilsExtra.auto
8+ from DistUtilsExtra.command import build_extra
9 except ImportError:
10 print >> sys.stderr, 'To build this program you need '\
11 'https://launchpad.net/python-distutils-extra'
12@@ -36,7 +37,7 @@
13 CLEANFILES = ['data/com.ubuntu.sso.service']
14
15 # XXX: This needs some serious cleanup
16-class SSOBuild(build.build):
17+class SSOBuild(build_extra.build_extra):
18 """Class to build the extra files."""
19
20 description = 'build extra files needed by ubuntu-sso-client'
21@@ -61,7 +62,7 @@
22 )
23
24 # Run the parent build command
25- build.build.run(self)
26+ build_extra.build_extra.run(self)
27
28
29 class SSOClean(clean.clean):

Subscribers

People subscribed via source and target branches