Code review comment for lp:~dpm/ubuntu-keyboard/add-catalan

Revision history for this message
Michael Sheldon (michael-sheldon) wrote :

Overall looks good, but could you add entries for Catalan in the languageIdToName function in qml/keys/LanguageMenu.qml and in the freeTextLanguageKeyboard and languageIsSupported functions in qml/KeyboardContainer.qml (these should really be redesigned to avoid the need for that, but that's currently fairly low on the priority list I'm afraid).

If you could also add the submission checklist from here: https://wiki.ubuntu.com/Process/Merges/Checklists/system-apps that'd help speed along acceptance as well.

Thanks!

review: Needs Fixing

« Back to merge proposal