Merge lp:~dpm/ubuntu-filemanager-app/add-object-name into lp:ubuntu-filemanager-app

Proposed by David Planella
Status: Merged
Approved by: David Planella
Approved revision: 232
Merged at revision: 232
Proposed branch: lp:~dpm/ubuntu-filemanager-app/add-object-name
Merge into: lp:ubuntu-filemanager-app
Diff against target: 12 lines (+1/-1)
1 file modified
src/app/qml/ui/PlacesPopover.qml (+1/-1)
To merge this branch: bzr merge lp:~dpm/ubuntu-filemanager-app/add-object-name
Reviewer Review Type Date Requested Status
Brendan Donegan Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+227699@code.launchpad.net

Commit message

Fix to get the tests to go to places working again. Going forward, we should probably add the objectName to the model in the plugin instead.

Description of the change

Fix to get the tests to go to places working again. Going forward, we should probably add the objectName to the model in the plugin instead.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

This has my approval

review: Approve
Revision history for this message
David Planella (dpm) wrote :

Top-approving as per QA feedback.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/app/qml/ui/PlacesPopover.qml'
2--- src/app/qml/ui/PlacesPopover.qml 2014-06-22 12:45:32 +0000
3+++ src/app/qml/ui/PlacesPopover.qml 2014-07-22 10:51:51 +0000
4@@ -83,7 +83,7 @@
5 model: PlacesModel {}
6
7 delegate: Standard {
8- objectName: model.objectName
9+ objectName: "place" + folderDisplayName(path).replace(/ /g,'')
10 property string name: folderDisplayName(path)
11
12 Label {

Subscribers

People subscribed via source and target branches