Code review comment for lp:~dpm/ubuntu-clock-app/i18n-module

Revision history for this message
dobey (dobey) wrote :

I would add an if() to check that ${ARGN} is empty and recurse over all paths if so, or just get rid of the path arguments list, and always recurse over everything.

If this makes things easier for the core apps in the short-term I think it's fine. But I don't think this is a long-term solution to fixing builds of translations. For that, I think we need to fix up intltool to behave well with cmake, and provide an Intltool.cmake.

It looks fine to me otherwise though.

review: Approve

« Back to merge proposal