Merge lp:~dpm/ubuntu-calculator-app/fix-desktop-title into lp:~ubuntu-calculator-dev/ubuntu-calculator-app/old_trunk

Proposed by David Planella
Status: Merged
Approved by: Alan Pope 🍺🐧🐱 πŸ¦„
Approved revision: 239
Merged at revision: 239
Proposed branch: lp:~dpm/ubuntu-calculator-app/fix-desktop-title
Merge into: lp:~ubuntu-calculator-dev/ubuntu-calculator-app/old_trunk
Diff against target: 22 lines (+5/-0)
1 file modified
ubuntu-calculator-app.qml (+5/-0)
To merge this branch: bzr merge lp:~dpm/ubuntu-calculator-app/fix-desktop-title
Reviewer Review Type Date Requested Status
Bartosz Kosiorek Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+216009@code.launchpad.net

Commit message

Fix the title bar on the desktop to be human-readable

Description of the change

Fix the title bar on the desktop to be human-readable, working around bug 1308343

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Bartosz Kosiorek (gang65) wrote :

It is works for me perfectly.
Why it is only workaround?

How final solution should looks like?

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ubuntu-calculator-app.qml'
2--- ubuntu-calculator-app.qml 2014-02-09 11:21:59 +0000
3+++ ubuntu-calculator-app.qml 2014-04-16 06:44:07 +0000
4@@ -18,6 +18,7 @@
5
6 import QtQuick 2.0
7 import Ubuntu.Components 0.1
8+import QtQuick.Window 2.0
9 import "Simple"
10 //import "Scientific"
11
12@@ -36,6 +37,10 @@
13 width: units.gu(50)
14 height: units.gu(75)
15
16+ // Workaround for bug #1308343
17+ property bool windowActive: typeof window != 'undefined'
18+ onWindowActiveChanged: window.title = i18n.tr("Calculator")
19+
20 Storage{
21 id: storage
22 }

Subscribers

People subscribed via source and target branches