Merge lp:~dpm/ubuntu-calculator-app/fix-desktop-l10n-1325626 into lp:~ubuntu-calculator-dev/ubuntu-calculator-app/old_trunk

Proposed by David Planella
Status: Merged
Approved by: Mihir Soni
Approved revision: 278
Merged at revision: 278
Proposed branch: lp:~dpm/ubuntu-calculator-app/fix-desktop-l10n-1325626
Merge into: lp:~ubuntu-calculator-dev/ubuntu-calculator-app/old_trunk
Diff against target: 31 lines (+5/-2)
2 files modified
com.ubuntu.calculator_calculator.desktop.in.in (+0/-1)
ubuntu-calculator-app.qmlproject (+5/-1)
To merge this branch: bzr merge lp:~dpm/ubuntu-calculator-app/fix-desktop-l10n-1325626
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Mihir Soni Approve
Review via email: mp+222284@code.launchpad.net

Commit message

Remove the x-Ubuntu-Gettext-Domain from the .desktop file, which causes the click scope not to load the inline translations.

Description of the change

Remove the x-Ubuntu-Gettext-Domain from the .desktop file, which causes the click scope not to load the inline translations.

To post a comment you must log in.
Revision history for this message
Mihir Soni (mihirsoni) wrote :

Looks good to me.
Thanks :)

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'com.ubuntu.calculator_calculator.desktop.in.in'
2--- com.ubuntu.calculator_calculator.desktop.in.in 2014-05-16 20:21:54 +0000
3+++ com.ubuntu.calculator_calculator.desktop.in.in 2014-06-06 07:34:41 +0000
4@@ -8,4 +8,3 @@
5 Icon=@ICON@
6 X-Ubuntu-Touch=true
7 X-Ubuntu-StageHint=SideStage
8-X-Ubuntu-Gettext-Domain=@PROJECT_NAME@
9
10=== modified file 'ubuntu-calculator-app.qmlproject'
11--- ubuntu-calculator-app.qmlproject 2014-05-09 15:13:20 +0000
12+++ ubuntu-calculator-app.qmlproject 2014-06-06 07:34:41 +0000
13@@ -19,13 +19,17 @@
14 Files {
15 filter: "README*"
16 }
17- /* Shows the translation files and the .pro file used to generate the .pot template */
18+ /* Shows the translation files and the .pot template */
19 Files {
20 filter: "*.po*"
21 }
22 Files {
23 filter: "CMakeLists.txt"
24 }
25+ /* Shows the desktop file in the project view */
26+ Files {
27+ filter: "*.desktop*"
28+ }
29 /* List of plugin directories passed to QML runtime */
30 importPaths: [ "." ,"/usr/lib/x86_64-linux-gnu/qt5/qml" ]
31 }

Subscribers

People subscribed via source and target branches