Merge lp:~dpm/reminders-app/fix-1289347-icon-deps into lp:reminders-app

Proposed by David Planella
Status: Merged
Approved by: Daniel Holbach
Approved revision: 120
Merged at revision: 126
Proposed branch: lp:~dpm/reminders-app/fix-1289347-icon-deps
Merge into: lp:reminders-app
Diff against target: 12 lines (+2/-1)
1 file modified
debian/control (+2/-1)
To merge this branch: bzr merge lp:~dpm/reminders-app/fix-1289347-icon-deps
Reviewer Review Type Date Requested Status
Daniel Holbach (community) Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+218513@code.launchpad.net

Commit message

Add dependency to the Suru icons package to get the mobile icons installed on the desktop

Description of the change

Add dependency to the Suru icons package to get the mobile icons installed on the desktop

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Daniel Holbach (dholbach) wrote :

Looks good and is what weather and music app are doing as well.

review: Approve
Revision history for this message
Alan Pope 🍺🐧🐱 πŸ¦„ (popey) wrote :

I tried to build this on my desktop and it failed:-

E: reminders-app source: not-binnmuable-all-depends-any reminders-app-autopilot -> reminders-app
E: reminders-app: missing-dependency-on-libc needed by usr/bin/reminders

Revision history for this message
Daniel Holbach (dholbach) wrote :

These lintian errors are unrelated. Might be worth opening another bug for it. I'll take a look at the problem in the meantime.

Revision history for this message
Daniel Holbach (dholbach) wrote :

The lintian errors also don't block the build. It still passes.

Revision history for this message
Daniel Holbach (dholbach) wrote :

Pushed my fixes to lp:~dholbach/reminders-app/some-lintian-fixes and will open a separate MP for it.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2014-05-06 18:40:53 +0000
3+++ debian/control 2014-05-06 21:25:49 +0000
4@@ -24,7 +24,8 @@
5 qtdeclarative5-ubuntu-ui-toolkit-plugin | qt-components-ubuntu,
6 qtdeclarative5-localstorage-plugin,
7 qtdeclarative5-qtquick2-plugin,
8- signon-plugin-oauth2 (>= 0.19-0~57~)
9+ signon-plugin-oauth2 (>= 0.19-0~57~),
10+ suru-icon-theme | ubuntu-mobile-icons,
11 Description: Reminders application
12 Note taking application powered by Evernote
13

Subscribers

People subscribed via source and target branches