Merge lp:~dpm/reminders-app/bug-1273704 into lp:reminders-app

Proposed by David Planella
Status: Merged
Approved by: Michael Zanetti
Approved revision: 47
Merged at revision: 45
Proposed branch: lp:~dpm/reminders-app/bug-1273704
Merge into: lp:reminders-app
Diff against target: 2 lines (+0/-0)
0 files modified
To merge this branch: bzr merge lp:~dpm/reminders-app/bug-1273704
Reviewer Review Type Date Requested Status
Michael Zanetti (community) Approve
Nekhelesh Ramananthan (community) Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+204218@code.launchpad.net

Commit message

Replaces the existing fixed-size 64x64px icon with a 240x225px one with the correct width/height ratio to fix bug 1273704

Description of the change

Replaces the existing fixed-size 64x64px icon with a 240x225px one with the correct width/height ratio to fix bug 1273704

To post a comment you must log in.
Revision history for this message
David Planella (dpm) wrote :

Actually, hold on on reviewing. Design tells me I should use a PNG for this one, but still it should have the right size ratio.

Revision history for this message
David Planella (dpm) wrote :

From the advice from Matthieu James: to avoid performance issues, I it's better to use PNG. Plus the SVG rendering engine in Qt does not handle some SVG features like clipping and masking, which can alter the rendering of the icon.

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

+1. The svg rendering in Qt is not good as I did some initial testing on the clock app. This is why all the icon resources on clock app are png.

review: Approve
Revision history for this message
Michael Zanetti (mzanetti) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'reminders.png'
2Binary files reminders.png 2014-01-19 13:59:12 +0000 and reminders.png 2014-01-31 12:55:25 +0000 differ

Subscribers

People subscribed via source and target branches