Merge lp:~dpm/music-app/add-mediascanner-dep into lp:music-app/trusty

[David Planella]

It seems that on the desktop adding grilo-plugins-0.2-mediascanner as a dependency is not enough to pull in mediascanner, thus adding an explicit dependency.

It seems that on the desktop adding grilo-plugins-0.2-mediascanner as a dependency is not enough to pull in mediascanner, thus adding an explicit dependency.

[Alan Pope 🍺🐧🐱 🦄 (popey)]

Looks good. Thanks.

review: Approve

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Continuous integration, rev:434
http://91.189.93.70:8080/job/music-app-ci/730/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-trusty/2212/console
    SUCCESS: http://91.189.93.70:8080/job/music-app-raring-amd64-ci/730
    SUCCESS: http://91.189.93.70:8080/job/music-app-saucy-amd64-ci/732
    SUCCESS: http://91.189.93.70:8080/job/music-app-trusty-amd64-ci/451

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/730/rebuild

review: Needs Fixing (continuous-integration)

[David Planella (dpm)]

So it seems that this should have already been taken care of by https://code.launchpad.net/~vthompson/qtgrilo/fixes-1241403/+merge/195297

However, the package with the fix never got built, thus the newly added dependency was never pulled.

review: Disapprove

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

review: Approve (continuous-integration)

[Victor Thompson (vthompson)]

dpm, thanks for figuring out what was going on here. I didn't realize this was reverted. Is there a reason you are marking this as disapprove? Do we intend on building a package from an older revision? I assume it'd be easier to push this fix and get that a package built for the new revision.

review: Needs Information

[Victor Thompson (vthompson)]

Nevermind, I didn't realize that this was being added directly to the music-app.

[Victor Thompson (vthompson)]

dpm, I think we should keep the dependency in the music-app so we don't have to fuss with the qt-grilo plugin. This was accidentally merged, but I think it is the right solution. Thanks! Marking as Merged and Approved.

review: Approve

=== modified file 'debian/control'
--- debian/control	2014-03-14 00:03:53 +0000
+++ debian/control	2014-04-25 11:59:11 +0000
@@ -13,6 +13,7 @@
 Package: music-app
 Architecture: all
 Depends: grilo-plugins-0.2-mediascanner,
+         mediascanner,
          qmlscene,
          qtdeclarative5-localstorage-plugin,
          qtdeclarative5-particles-plugin,