Merge lp:~dpm/help-app/more-phone-navigation-fixes into lp:~ubuntu-touch-coreapps-drivers/help-app/trunk

Proposed by David Planella
Status: Merged
Merged at revision: 107
Proposed branch: lp:~dpm/help-app/more-phone-navigation-fixes
Merge into: lp:~ubuntu-touch-coreapps-drivers/help-app/trunk
Diff against target: 30 lines (+14/-1)
1 file modified
edit-here/themes/phone/static/css/app.css (+14/-1)
To merge this branch: bzr merge lp:~dpm/help-app/more-phone-navigation-fixes
Reviewer Review Type Date Requested Status
Daniel Holbach (community) Approve
Review via email:

Description of the change

Hardcode the max number of tabs shown on the phone to 8 until the bug in the app container to support tab scrolling is fixed.

<daker> the max-height is limited to 250px (5 tabs), but you should be able to scroll over the tabs to display the others
 the issue that ubuntu-html5-launcher is using qtwebkit for some reason which doesn't recognize -webkit-overflow-scrolling: touch;
<dpm> daker, oh, I see. But even if scrolling would work, my concern would be that there is no visual indication for the user that the tabs can do scrolling. If it were working, would -webkit-overflow-scrolling show a slider or something?
<daker> yes it should

To post a comment you must log in.
Revision history for this message
Daniel Holbach (dholbach) wrote :

Thanks. Great work!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'edit-here/themes/phone/static/css/app.css'
2--- edit-here/themes/phone/static/css/app.css 2015-03-18 10:03:45 +0000
3+++ edit-here/themes/phone/static/css/app.css 2015-03-18 12:09:04 +0000
4@@ -40,11 +40,24 @@
5 display: none;
6 }
8+/* Do not show links on the
9+ front page until we've figured out
10+ how to make them work properly */
11 #index a {
12 display: none;
13 }
15+/* Disable links until they work
16+ properly */
17 a {
18 pointer-events: none;
19 cursor: default;
21\ No newline at end of file
24+/* Disable this when the app container
25+ properly supports tab scrolling.
26+ We hardcode support for showing
27+ 8 tabs (50px each) */
28+[data-role="tabs"] {
29+ max-height: 400px !important;


People subscribed via source and target branches