Merge lp:~dpm/help-app/more-phone-navigation-fixes into lp:~ubuntu-touch-coreapps-drivers/help-app/trunk
Proposed by
David Planella
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 107 | ||||
Proposed branch: | lp:~dpm/help-app/more-phone-navigation-fixes | ||||
Merge into: | lp:~ubuntu-touch-coreapps-drivers/help-app/trunk | ||||
Diff against target: |
30 lines (+14/-1) 1 file modified
edit-here/themes/phone/static/css/app.css (+14/-1) |
||||
To merge this branch: | bzr merge lp:~dpm/help-app/more-phone-navigation-fixes | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Daniel Holbach (community) | Approve | ||
Review via email:
|
Description of the change
Hardcode the max number of tabs shown on the phone to 8 until the bug in the app container to support tab scrolling is fixed.
<daker> the max-height is limited to 250px (5 tabs), but you should be able to scroll over the tabs to display the others
the issue that ubuntu-
<dpm> daker, oh, I see. But even if scrolling would work, my concern would be that there is no visual indication for the user that the tabs can do scrolling. If it were working, would -webkit-
<daker> yes it should
To post a comment you must log in.
Thanks. Great work!