Merge lp:~dpm/address-book-app/small-i18n-fixes into lp:address-book-app
Proposed by
David Planella
Status: | Rejected |
---|---|
Rejected by: | Renato Araujo Oliveira Filho |
Proposed branch: | lp:~dpm/address-book-app/small-i18n-fixes |
Merge into: | lp:address-book-app |
Diff against target: |
37 lines (+3/-3) 3 files modified
src/imports/ContactView/ContactFetchError.qml (+1/-1) src/imports/MainWindow.qml (+1/-1) src/imports/Ubuntu/Contacts/ContactDetailPickerPhoneNumberDelegate.qml (+1/-1) |
To merge this branch: | bzr merge lp:~dpm/address-book-app/small-i18n-fixes |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Leo Arias (community) | Approve | ||
PS Jenkins bot | continuous-integration | Approve | |
Ubuntu Phablet Team | Pending | ||
Review via email: mp+228932@code.launchpad.net |
Commit message
Marks for translation the "No phone numbers" message that appears when a contact has no numbers set.
Description of the change
Marks for translation the "No phone numbers" message that appears when a contact has no numbers set. A couple of other untranslatable messages have been fixed as well.
This branch (or a follow-up one) should probably update the .pot file as well, but I couldn't figure out how it's done in system apps. Is there a cmake rule to do it? Any hints welcome!
To post a comment you must log in.
Unmerged revisions
- 259. By David Planella
-
Marked several strings for translation
PASSED: Continuous integration, rev:259 jenkins. qa.ubuntu. com/job/ address- book-app- ci/654/ jenkins. qa.ubuntu. com/job/ address- book-app- utopic- amd64-ci/ 107 jenkins. qa.ubuntu. com/job/ address- book-app- utopic- armhf-ci/ 107 jenkins. qa.ubuntu. com/job/ address- book-app- utopic- armhf-ci/ 107/artifact/ work/output/ *zip*/output. zip jenkins. qa.ubuntu. com/job/ address- book-app- utopic- i386-ci/ 107 jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- utopic- touch/2765 jenkins. qa.ubuntu. com/job/ generic- mediumtests- utopic/ 2206 jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- runner- mako/2855 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- utopic- armhf/4008 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- utopic- armhf/4008/ artifact/ work/output/ *zip*/output. zip s-jenkins. ubuntu- ci:8080/ job/touch- flash-device/ 10718 jenkins. qa.ubuntu. com/job/ autopilot- testrunner- otto-utopic/ 1826 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- utopic- amd64/2465 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- utopic- amd64/2465/ artifact/ work/output/ *zip*/output. zip
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/address- book-app- ci/654/ rebuild
http://