Merge lp:~dpb/storm/db-setup-pg-shmmax into lp:storm

[David Britton]

On pg9.1 and certain memory configurations, the settings introduced by dev/db-setup can overrun the default shmmax settings on the kernel. This change catches the error and attempts to tune the kernel correctly.

[lp:~dpb/storm/db-setup-pg-shmmax]

458. By David Britton on 2013-02-26

s/foo/output/

459. By David Britton on 2013-02-26

s/-E/-r/ on sed command

[Andreas Hasenack (ahasenack)]

Just make sure $size is a number before writing it to that file and feeding it to sysctl. That regexp might fail one day if the error message from postgresql changes.

review: Approve

[lp:~dpb/storm/db-setup-pg-shmmax]

460. By David Britton on 2013-02-26

use is_number bash function to test, before setting kernel tunable

=== modified file 'dev/db-setup'
--- dev/db-setup	2012-03-28 10:36:14 +0000
+++ dev/db-setup	2013-02-26 21:42:20 +0000
@@ -5,12 +5,33 @@
 PGINIT=/etc/init.d/postgresql*
 MYSQL_PRIVS="GRANT ALL PRIVILEGES ON *.* TO '$USER'@'localhost' IDENTIFIED BY '' WITH GRANT OPTION;"
 
+is_number() {
+    test "$1" && printf '%f' "$1" >/dev/null;
+}
+
+# Restart service and examine output to attempt to adjust kernel tunables
+restart_service() {
+    sudo $PGINIT stop
+    set +e
+    output=$(sudo $PGINIT start 2>&1)
+    rc=$?
+    set -e
+    if [ $rc -ne 0 ]; then
+        size=$(echo $output | grep -E 'size=[0-9]+' | sed -r 's/.*size=([0-9]+).*/\1/')
+        is_number $size
+        SYSCTLCONF=/etc/sysctl.d/90-storm.conf
+        sudo sh -c "echo kernel.shmmax = $size > $SYSCTLCONF"
+        sudo sysctl -p $SYSCTLCONF
+        sudo $PGINIT start
+    fi
+}
+
 echo " * Fixing localhost access to postgres, restarting service"
 sudo sed -i.bak -r 's/(host.*127\.0\.0\.1.*)\s+\w+$/\1 trust/' $PGHBA
 sudo sed -i.bak -r 's/(host.*::1\/128.*)\s+\w+$/\1 trust/' $PGHBA
 sudo sed -i.bak -r 's/(host.*::1\/128.*)\s+\w+$/\1 trust/' $PGHBA
 sudo sed -i.bak -r 's/#(max_prepared_transactions.*)= 0/\1 = 200/' $PGCONF
-sudo $PGINIT restart
+restart_service
 
 echo " * Create postgres superuser ($USER - will fail if existing)"
 # If this fails, we will get errors later, so don't fail.
@@ -28,5 +49,3 @@
 mysqldump -u $USER storm_test > /dev/null
 
 echo " * All Done."
-
-