Merge lp:~dpb/orange-box/extra-disk-vm into lp:orange-box

Proposed by David Britton
Status: Merged
Merged at revision: 460
Proposed branch: lp:~dpb/orange-box/extra-disk-vm
Merge into: lp:orange-box
Diff against target: 12 lines (+1/-1)
1 file modified
usr/bin/orange-box-add-virtual-nodes (+1/-1)
To merge this branch: bzr merge lp:~dpb/orange-box/extra-disk-vm
Reviewer Review Type Date Requested Status
Adam Collard (community) Approve
Orange Box Pending
Review via email: mp+232448@code.launchpad.net

Description of the change

Add an extra disk (2G) to the vms created by the add-virtual-nodes script

To post a comment you must log in.
Revision history for this message
Adam Collard (adam-collard) wrote :

Looks good!

review: Approve
Revision history for this message
David Britton (dpb) wrote :

Adam, thanks. Can you merge this in for me?

On Wed, Aug 27, 2014 at 10:41 AM, Adam Collard <email address hidden>
wrote:

> Review: Approve
>
> Looks good!
> --
>
> https://code.launchpad.net/~davidpbritton/orange-box/extra-disk-vm/+merge/232448
> You are the owner of lp:~davidpbritton/orange-box/extra-disk-vm.
>

--
David Britton <email address hidden>

Revision history for this message
Adam Collard (adam-collard) wrote :

> Adam, thanks. Can you merge this in for me?

I'd love to. Unfortunately only Dustin (https://launchpad.net/~kirkland) can land branches at the moment.

Dustin - what needs to happen for me to be given rights on lp:orangebox ?

Revision history for this message
Dustin Kirkland  (kirkland) wrote :

I'll test this, commit and release later today. Thanks!

Dustin Kirkland
Canonical, Ltd.

On Wed, Aug 27, 2014 at 12:01 PM, Adam Collard
<email address hidden> wrote:
>> Adam, thanks. Can you merge this in for me?
>
> I'd love to. Unfortunately only Dustin (https://launchpad.net/~kirkland) can land branches at the moment.
>
> Dustin - what needs to happen for me to be given rights on lp:orangebox ?
> --
> https://code.launchpad.net/~davidpbritton/orange-box/extra-disk-vm/+merge/232448
> You are subscribed to branch lp:orange-box.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'usr/bin/orange-box-add-virtual-nodes'
2--- usr/bin/orange-box-add-virtual-nodes 2014-07-25 19:16:24 +0000
3+++ usr/bin/orange-box-add-virtual-nodes 2014-08-27 16:38:20 +0000
4@@ -45,7 +45,7 @@
5 virsh destroy $hostname || true
6 virsh undefine $hostname || true
7 echo "INFO: Installing virtual machine"
8- virt-install --debug --name $hostname --ram 4096 --disk=path=/var/lib/orange-box/${hostname}.img,size=20 --vcpus=2 --os-type=linux --pxe --network=bridge=br0 --network=bridge=br0 --boot network || true
9+ virt-install --debug --name $hostname --ram 4096 --disk=path=/var/lib/orange-box/${hostname}.img,size=20 --disk=path=/var/lib/orange-box/${hostname}-2.img,size=2 --vcpus=2 --os-type=linux --pxe --network=bridge=br0 --network=bridge=br0 --boot network || true
10 virsh console $hostname || true
11 virsh autostart $hostname
12 mac=$(virsh dumpxml $hostname | python -c 'import sys, lxml.etree; print list(lxml.etree.parse(sys.stdin).iter("mac"))[0].get("address")')

Subscribers

People subscribed via source and target branches