Merge lp:~dpb/landscape-charm/strip-url-newline-1411353 into lp:~landscape/landscape-charm/trunk
Proposed by
David Britton
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | David Britton | ||||
Approved revision: | 218 | ||||
Merged at revision: | 217 | ||||
Proposed branch: | lp:~dpb/landscape-charm/strip-url-newline-1411353 | ||||
Merge into: | lp:~landscape/landscape-charm/trunk | ||||
Diff against target: |
82 lines (+34/-5) 2 files modified
hooks/hooks.py (+4/-2) hooks/test_hooks.py (+30/-3) |
||||
To merge this branch: | bzr merge lp:~dpb/landscape-charm/strip-url-newline-1411353 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Andreas Hasenack | Approve | ||
Adam Collard (community) | Approve | ||
Review via email: mp+246628@code.launchpad.net |
Commit message
Strip newlines from url before passing to cURL.
Description of the change
Strip newlines from url before passing to cURL.
To post a comment you must log in.
Change is good, I think the tests need to be modified as suggested below, to make them easier to grok