lp:~dpb/juju-core/1192706-empty-string-config

Branch merges

Propose for merging

No branches dependent on this one.

Rejected for merging into lp:~go-bot/juju-core/trunk

William Reade (community): Needs Fixing on 2013-06-26

Diff: 37 lines (+3/-5)

2 files modified

charm/config.go (+0/-2)
charm/config_test.go (+3/-3)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1192706: config: empty strings return null with --format=json

Critical

Fix Released

Link a bug report

Related blueprints

1328. By David Britton on 2013-06-26

Remove note about running without JUJU_ENV, filed bug: https://bugs.launchpad.net/juju-core/+bug/1194902

1327. By David Britton on 2013-06-25

Warn about setting JUJU_ENV in CONTRIB file

1326. By David Britton on 2013-06-25

Simple fix for lp# 1192706

1325. By Roger Peppe on 2013-06-24

[r=rogpeppe] state/apiserver: logging in changes the API

This is a step towards serving just the API
that each client is supposed to see.
For the time being, we still have one
big root object, but this will be split up
in subsequent CLs.

https://codereview.appspot.com/10447047/

1324. By Jeroen T. Vermeulen on 2013-06-24

[r=jtv] Implement Environ.SetConfig for Azure provider.

1323. By Raphaël Badin on 2013-06-24

[r=rvb] Implement storage methods in the Azure provider.

1322. By Ian Booth on 2013-06-24

[r=jameinel] Remove Metadata() method from Instance interface

The machine metadata is not aways available, and is only used
when startInstance is called. So have startInstance return the
metadata separately along with the instance.

https://codereview.appspot.com/10384049/

1321. By Frank Mueller on 2013-06-21

[r=themue] ec2: moved the http storage reader and tests

Moved the HTTP based StorageReader and the test server
for it to environs/ec2 and adopted those changes at
the synctools.

https://codereview.appspot.com/10296046/

1320. By Roger Peppe on 2013-06-21

[r=rogpeppe] state/apiserver/machine: add AgentAPI.SetPasswords

We also add the client side, and implement it in such a
way that it can easily be incorporated into the unit agent
API.

https://codereview.appspot.com/10449044/

1319. By William Reade on 2013-06-21

[r=fwereade] state: aggressive removal of pending units

In response to lp:1190715, we make the following changes:

  * service destruction now adds a cleanup doc that churns through all a
   service's units destroying or removing them where possible.
  * unit destruction short-circuiting is now attempted when the unit agent
   has not yet set a status.

...and make the following opportunistic changes for sanity's and clarity's
sakes:

  * clarify and make consistent the similar transaction-building loops
   in service.go and unit.go (in particular, Unit.Remove was noticeably
 simplified).
  * resolve races around unit destruction in which charm changes and
   machine assignment changes are not properly taken into account.

...supported by testing changes as follows:

  * added SetRetryHooks for verifying a commonly-interesting-to-test
   scenario (set up txn; break txn; verify effect of retried txn)
  * SetBeforeHook became SetBeforeHooks, because that happened while I
   was figuring out SetRetryHooks, and I decided it was a nice change.
  * preventUnitDestroyRemove is much simpler and no longer needs the
   state argument; this is annoyingly noisy.
  * assertUnitLife and assertUnitRemoved were taken off UnitSuite and used
   elsewhere.

The macroscopic effect of this is currently limited. Units that are manually
removed will be removed more quickly more often, which is nice; but the big
problem in lp:1190715 is related to service destruction, and that's not
directly helped by this branch.

When we merge a cleanup worker integration branch, though, this bug will be fixed pretty nicely for all environments running this code (on both client and server).