Juju Charms Collection
landscape-client package

Merge lp:~dpb/charms/precise/landscape-client/1273788-change-relation-interface into lp:charms/landscape-client

  1. Precise Pangolin (12.04)
  2. 1273788-change-relation-interface
  3. Merge into trunk
Proposed by David Britton
Status: Merged
Approved by: David Britton
Approved revision: 36
Merged at revision: 36
Proposed branch: lp:~dpb/charms/precise/landscape-client/1273788-change-relation-interface
Merge into: lp:charms/landscape-client
Diff against target: 12 lines (+1/-1)
1 file modified
metadata.yaml (+1/-1)
To merge this branch: bzr merge lp:~dpb/charms/precise/landscape-client/1273788-change-relation-interface
Reviewer Review Type Date Requested Status
Chad Smith Approve
Andreas Hasenack Approve
Review via email: mp+203608@code.launchpad.net

Description of the change

change the registration relation interface name. naming it http is confusing, wrong, and leads to weird behavior where people expect things to work. i.e.:

juju add-relation principal landscape-client

If principal has an http interface, it will prefer that over the subordinate version.

To post a comment you must log in.
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

+1

review: Approve
Revision history for this message
Chad Smith (chad.smith) wrote :

+1 deployment w/ updated lds-quickstart charm works fine and registered the unit

Revision history for this message
Chad Smith (chad.smith) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'metadata.yaml'
2--- metadata.yaml 2013-05-31 14:58:24 +0000
3+++ metadata.yaml 2014-01-28 18:01:57 +0000
4@@ -12,7 +12,7 @@
5 interface: juju-info
6 scope: container
7 registration:
8- interface: http
9+ interface: landscape-registration
10 ceph-client:
11 interface: ceph-client
12 scope: container

Subscribers

People subscribed via source and target branches