Merge lp:~dpb/charms/precise/landscape-client/1116370-charm-store-fix into lp:~mark-mims/charms/precise/landscape-client/trunk

Proposed by David Britton
Status: Rejected
Rejected by: Mark Mims
Proposed branch: lp:~dpb/charms/precise/landscape-client/1116370-charm-store-fix
Merge into: lp:~mark-mims/charms/precise/landscape-client/trunk
Prerequisite: lp:~bjornt/charms/precise/landscape-client/save-juju-env
Diff against target: 12 lines (+1/-1)
1 file modified
metadata.yaml (+1/-1)
To merge this branch: bzr merge lp:~dpb/charms/precise/landscape-client/1116370-charm-store-fix
Reviewer Review Type Date Requested Status
Kapil Thangavelu (community) Approve
Review via email: mp+146671@code.launchpad.net

Description of the change

Fix for bug #1116370 to expose the charm properly on the charm store. Change name of relation juju-info to container to comply with informally reserved namespace 'juju-' on relation names.

To post a comment you must log in.
Revision history for this message
Kapil Thangavelu (hazmat) wrote :

lgtm, thanks.

review: Approve
Revision history for this message
Mark Mims (mark-mims) wrote :

rejecting... the charm was incorrectly promulgated, so these MPs are against the wrong branch.

Please resubmit against lp:charms/landscape-client (which is currently correct)

Unmerged revisions

19. By David Britton

Merge in save-juju-env branch

18. By David Britton

relation: juju-info => container

17. By David Britton

merge in cleanup from bjornt

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== renamed file 'hooks/juju-info-relation-joined' => 'hooks/container-relation-joined'
2=== modified file 'metadata.yaml'
3--- metadata.yaml 2013-01-17 23:20:22 +0000
4+++ metadata.yaml 2013-02-05 16:46:27 +0000
5@@ -8,6 +8,6 @@
6 Landscape account.
7 subordinate: true
8 requires:
9- juju-info:
10+ container:
11 interface: juju-info
12 scope: container

Subscribers

People subscribed via source and target branches

to all changes: