Code review comment for ~dparv/charm-logrotated:bug_1833722

Revision history for this message
Paul Goins (vultaire) wrote :

I would prefer if we leverage charms.layer.basic.activate_venv(), as described in one of the diff comments here, to better ensure consistency of behavior between actions and hooks. (In conjunction with reverting the sshebang line.)

Other than that, the other changes seem okay, although I don't think they really change behavior.

review: Needs Fixing

« Back to merge proposal